Avidemux Forum

Avidemux => Main version 2.6 => Topic started by: bugreport on April 21, 2017, 04:49:49 PM

Title: Cropped text in filter list
Post by: bugreport on April 21, 2017, 04:49:49 PM
avidemux_2.7.0_r170420_win64.exe:
1. Open some video file.
2. Select codec (ex. x264).
3. Open filter list.
4. Observe cropped text.

Screenshot attached.

OS: Win7SP1x64, Language: Russian
Title: Re: Cropped text in filter list
Post by: eumagga0x2a on April 21, 2017, 06:22:12 PM
Please specify which font settings you use.
Title: Re: Cropped text in filter list
Post by: bugreport on April 22, 2017, 04:29:39 AM
Quote from: eumagga0x2a on April 21, 2017, 06:22:12 PM
Please specify which font settings you use.
What exactly do you mean?
I can't find font settings in Avidemux.

Maybe you are talking about system DPI settings?
In this case, the setting is 100% scale.
My monitor is not HiDPI (1280x1024), so Windows automatically selected this option.
Title: Re: Cropped text in filter list
Post by: eumagga0x2a on April 22, 2017, 06:34:22 AM
Quote from: bugreport on April 22, 2017, 04:29:39 AM
Quote from: eumagga0x2a on April 21, 2017, 06:22:12 PM
Please specify which font settings you use.
Maybe you are talking about system DPI settings?

Exactly.

QuoteIn this case, the setting is 100% scale.
My monitor is not HiDPI (1280x1024), so Windows automatically selected this option.

Meanwhile I could reproduce the issue which infamously striked at some DPI values but not at others, additionally depending on the language, and pushed a workaround adding 6px to the filter list items' height.

The underlying problem is the usage of QFontMetrics::boundingRect which seems not to take varying font sizes specified by the rendered string into account.

Thank you for your report.
Title: Re: Cropped text in filter list
Post by: p3trus on April 24, 2017, 09:20:12 PM
...while this was solved in 2.6.19 Final, the cropped descriptions are back in r170420_win64Qt5_402 - just for information.
(using no DPI scaling either, ie 100%)
Title: Re: Cropped text in filter list
Post by: eumagga0x2a on April 24, 2017, 09:28:54 PM
http://avidemux.org/nightly/win32/avidemux_2.7.0_r170422_win32.exe (http://avidemux.org/nightly/win32/avidemux_2.7.0_r170422_win32.exe) is fixed as is http://avidemux.org/nightly/win64_support/avidemux_r170424_win64Qt5_3.zip (http://avidemux.org/nightly/win64_support/avidemux_r170424_win64Qt5_3.zip).

2.6.19 suffered from rendering artifacts depicted in https://github.com/mean00/avidemux2/pull/144 (https://github.com/mean00/avidemux2/pull/144), this is why some action was needed in the first place.