Author Topic: Avidemux patch  (Read 4971 times)

KoolAidMan

  • Jr. Member
  • **
  • Posts: 68
Avidemux patch
« on: November 26, 2014, 10:27:40 AM »
Patch sent via email
« Last Edit: December 01, 2014, 07:54:43 AM by KoolAidMan »

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10895
Re: HEVC encoding, VP9 decoding, and more!
« Reply #1 on: November 27, 2014, 09:44:33 AM »
That's weird
Normally all actions are through the UI callback, they should be coming from a single thread

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10895
Re: HEVC encoding, VP9 decoding, and more!
« Reply #2 on: November 27, 2014, 10:46:28 AM »
That one is coming from the UI callback
i.e. if you see
HandleAction
It is the central dispatcher from UI events

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10895
Re: HEVC encoding, VP9 decoding, and more!
« Reply #3 on: November 27, 2014, 11:55:35 AM »
What i've seen is some corner cases errors in the timing computation
That ends up requesting a frame at a time that does not exist => assert => crash

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10895
Re: HEVC encoding, VP9 decoding, and more!
« Reply #4 on: November 28, 2014, 10:10:24 AM »
Probably a race

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10895
Re: HEVC encoding, VP9 decoding, and more!
« Reply #5 on: November 29, 2014, 07:35:33 AM »
It might happen between encoding threads & GUI/screen refresh threads
Taken individually they are thread safe

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10895
Re: HEVC encoding, VP9 decoding, and more!
« Reply #6 on: November 29, 2014, 02:20:05 PM »
Try using the CLI version to check if it is somehow linked to Qt4

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10895
Re: HEVC encoding, VP9 decoding, and more!
« Reply #7 on: November 30, 2014, 07:44:30 AM »
Cannot reproduce

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10895
Re: HEVC encoding, VP9 decoding, and more!
« Reply #8 on: November 30, 2014, 10:30:10 AM »
Sure
It will stay in beta  for  a bit
When switching ffmpeg version usually some things get broken

AQUAR

  • Hero Member
  • *****
  • Posts: 982
Re: Avidemux patch
« Reply #9 on: December 01, 2014, 09:25:48 AM »
It was interesting to follow the discussion between Mean and KoolAidMan about the HEVC development and the tangential issues.
Now this thread is one sided, without KoolAidMan components, and holds no informative value to members (other than - patch has been submitted!).
So what happened to this thread?

« Last Edit: December 01, 2014, 10:14:13 AM by AQUAR »

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 5337
Re: Avidemux patch
« Reply #10 on: December 05, 2014, 09:44:55 AM »
User can delete own postings. Patches can be found in commits from nov 21, 2014 onwards by kap: https://github.com/mean00/avidemux2/commit/176fd343b7f09a28e1b3858d2194594729f44351
« Last Edit: December 05, 2014, 11:25:16 AM by Jan Gruuthuse »

AQUAR

  • Hero Member
  • *****
  • Posts: 982
Re: Avidemux patch
« Reply #11 on: December 05, 2014, 11:05:25 AM »
Thanks Jan,

The OP send me a private message about the removed content.