Author Topic: Support for X265_BUILD >=45  (Read 2216 times)

KoolAidMan

  • Jr. Member
  • **
  • Posts: 68
Support for X265_BUILD >=45
« on: February 13, 2015, 02:40:08 AM »
This patch removes the reference to an option for fast coding unit analysis through short circuiting when no residual was encoded. The reason it is being removed is because the x265 developers are no longer supporting this feature. https://bitbucket.org/multicoreware/x265/commits/9ab104096834f51bd799ea1cf1160092f8182944

This option was not being used in avidemux, except for during the debug print of the x265 settings. Note that the x265 developers also forgot to increment the X265_BUILD number, so there are multiple X265_BUILD == 45. Since this flag wasn't actually being used in avidemux, I simply removed the printf for the boolean value. It was a one-line change.

The patch has been attached. Apply the patch with "patch -p1 < bEnableCbfFastModeV45.diff".

Thanks mean, and let me know if you have any questions.

KoolAidMan

  • Jr. Member
  • **
  • Posts: 68
Re: Support for X265_BUILD >=45
« Reply #1 on: February 13, 2015, 06:55:40 AM »
Hi mean. I noticed that you had just committed a similar change on github. https://github.com/mean00/avidemux2/commit/c49f9aba08e0a0b0a2ad35c10877fc5a468afcaf

What do you mean by 'probably not enough?' In this particular case, there is no replacement for the option, so removing the reference is all we can do. It both unfortunate and exciting that the x265 API is changing so frequently lately. I will continue to support the x265 plugin with updates until the API eventually stabilizes. Let me know if there's anything I can do to help on this front.

(And hopefully next time the developers of x265 will remember to increment the version number when they change the public API. They forgot this time.)

Thanks!
« Last Edit: February 13, 2015, 07:01:57 AM by KoolAidMan »