Author Topic: Translations in the "adm" context in the main menu are currently broken  (Read 380 times)

eumagga0x2a

  • Hero Member
  • *****
  • Posts: 847
Something has broken translations in the main menu in the "adm" context, e.g. all those from myOwnMenu.h. It would be easy to point to [i18n] Make more strings translatable (Daniel Amm), but currently I don't see how it could have caused this issue.

Adding new German translations for strings in "qgui2" and in "qgui2menu" works:

Code: [Select]
diff --git a/avidemux/qt4/i18n/avidemux_de.ts b/avidemux/qt4/i18n/avidemux_de.ts
index 3d82ee0..6c4991b 100644
--- a/avidemux/qt4/i18n/avidemux_de.ts
+++ b/avidemux/qt4/i18n/avidemux_de.ts
@@ -2,6 +2,56 @@
 <!DOCTYPE TS>
 <TS version="2.1" language="de_DE">
 <context>
+    <name>qgui2</name>
+    <message>
+        <source>Recent Files</source>
+        <translation>Zuletzt verwendete &amp;Dateien</translation>
+    </message>
+    <message>
+        <source>Recent Projects</source>
+        <translation>Zuletzt verwendete &amp;Projekte</translation>
+    </message>
+</context>
+<context>
+    <name>qgui2menu</name>
+    <message>
+        <source>Project Script</source>
+        <translation>P&amp;rojekt-Skript</translation>
+    </message>
+    <message>
+        <source> Project</source>
+        <translation> Projekt</translation>
+    </message>
+    <message>
+        <source>&amp;Run Project...</source>
+        <translation>P&amp;rojekt ausf├╝hren...</translation>
+    </message>
+    <message>
+        <source>&amp;Debug Project...</source>
+        <translation>Projekt &amp;debuggen...</translation>
+    </message>
+    <message>
+        <source>Save &amp;As Project...</source>
+        <translation>&amp;Als Projekt speichern...</translation>
+    </message>
+    <message>
+        <source>Scripting Shell</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source> Shell</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>Scripting Reference</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source> Reference</source>
+        <translation type="unfinished"></translation>
+    </message>
+</context>
+<context>
     <name></name>
     <message>
         <source>MPEG-2 requant</source>

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10771
Re: Translations in the "adm" context in the main menu are currently broken
« Reply #1 on: September 01, 2016, 05:55:23 PM »
Confirmed

eumagga0x2a

  • Hero Member
  • *****
  • Posts: 847
Re: Translations in the "adm" context in the main menu are currently broken
« Reply #2 on: September 01, 2016, 06:48:10 PM »
Fixed by [i18n] More translatable string (Daniel Amm), the culprit was

Code: [Select]
@@ -485,7 +485,7 @@ bool MainWindow::buildMenu(QMenu *root,MenuEntry *menu, int nb)
     for(int i=0;i<nb;i++)
     {
         MenuEntry *m=menu+i;
-        QString qs=QString::fromUtf8(QT_TRANSLATE_NOOP("adm",m->text.c_str()));
+        QString qs=QString::fromUtf8(m->text.c_str());
         switch(m->type)
         {
             case MENU_SEPARATOR:

in

Code: [Select]
diff --git a/avidemux/qt4/ADM_userInterfaces/ADM_gui/Q_gui2.cpp b/avidemux/qt4/ADM_userInterfaces/ADM_gui/Q_gui2.cpp
from [i18n] Make more strings translatable (Daniel Amm).

Thanks!