Author Topic: fixed: Menu access availabilty 2.6.18 / Qt5 2017/03/14  (Read 536 times)

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 5573
fixed: Menu access availabilty 2.6.18 / Qt5 2017/03/14
« on: March 13, 2017, 10:46:19 AM »
Fixed: commit 22aaede            [UI] Disable menu items during playback, fix menus disabled after drag-n-drop
After installing todays build:
723b908            Merge branch 'master' of github.com:mean00/avidemux2
I noticed the menu is (partial) unavailable until you played the loaded video 1st.
Could you check and confirm the issue?
« Last Edit: March 14, 2017, 06:49:16 AM by Jan Gruuthuse »

eumagga0x2a

  • Hero Member
  • *****
  • Posts: 1379
Re: Menu access availabilty 2.6.18 / Qt5
« Reply #1 on: March 13, 2017, 12:07:20 PM »
It should not (and it doesn't) matter that a video was played, but it must be loaded. Disabling unusable menu items depending on context is the purpose of the merged first patch. More to follow.

edit: I didn't notice any anomalies during my testing, but if I missed something, it would be helpful to know which particular menu items were disabled after a video was loaded but got enabled once it was played (just played, no meddling with markers and such).
« Last Edit: March 13, 2017, 12:17:20 PM by eumagga0x2a »

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 5573
Not Ok
« Reply #2 on: March 13, 2017, 01:24:08 PM »
I was able to narrow this down.
Indicator is when video is loaded that above left icons (save and info) stay grey. (see attached VideoLoadedNotOK)
when this is happening several options are greyed out in several menus
Example Edit menu: options greyed out Cut, Copy, Delete, Set Marker A, Set Marker B & Reset Markers (see attached EditNotOK)


Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 5573
OK
« Reply #3 on: March 13, 2017, 01:26:57 PM »
With video loaded normally you would get:
« Last Edit: March 13, 2017, 01:29:42 PM by Jan Gruuthuse »

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 5573
Re: Menu access availabilty 2.6.18 / Qt5
« Reply #4 on: March 13, 2017, 01:32:07 PM »
video forwarded to developer(s) pm
« Last Edit: March 13, 2017, 01:38:53 PM by Jan Gruuthuse »

eumagga0x2a

  • Hero Member
  • *****
  • Posts: 1379
Re: Menu access availabilty 2.6.18 / Qt5
« Reply #5 on: March 13, 2017, 01:54:37 PM »
Thanks, never got loaded video not detected in my testing. Some refresh issues with QtGl? Will retest later today.

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 5573
Re: Menu access availabilty 2.6.18 / Qt5
« Reply #6 on: March 13, 2017, 02:27:29 PM »
Is Drag and Drop related/required. Behaviour not limited to posted .mkv. Does the same with mpeg-ts.
Happens on all selected Display Options.

Preferences: [Display]: OpenGl, VDPAU, Xvideo & QT
with and without selected:
Gui Rendering Options
[ ] Enable OpenGl support

Loading with recent file all is OK.

eumagga0x2a

  • Hero Member
  • *****
  • Posts: 1379
Re: Menu access availabilty 2.6.18 / Qt5
« Reply #7 on: March 13, 2017, 03:05:09 PM »
Thank you for the hint. Indeed, I didn't test with drag&drop. Quite possible that it doesn't fire the signal.

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 5573
Re: Menu access availabilty 2.6.18 / Qt5
« Reply #8 on: March 13, 2017, 04:18:10 PM »
Took me a while to understand what was going on and test this.

eumagga0x2a

  • Hero Member
  • *****
  • Posts: 1379
Re: Menu access availabilty 2.6.18 / Qt5
« Reply #9 on: March 13, 2017, 06:45:36 PM »
I've submitted a pull request which includes the fix for this bug. Thank you for catching this.

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 5573
Re: Menu access availabilty 2.6.18 / Qt5
« Reply #10 on: March 14, 2017, 06:43:53 AM »
Fixed: commit 22aaede            [UI] Disable menu items during playback, fix menus disabled after drag-n-drop
Thanks for fixing, today's build does work fine now.
« Last Edit: March 14, 2017, 06:49:29 AM by Jan Gruuthuse »

me444

  • Full Member
  • ***
  • Posts: 114
Re: fixed: Menu access availabilty 2.6.18 / Qt5 2017/03/14
« Reply #11 on: March 14, 2017, 05:42:10 PM »
Another defect apperars to be related to this issue:

Win7 64 bit, nightlies after march 04:
if you start ADM on a selected file from the windows explorer environment
using the ShellExecute resp. ShellExecuteEx  (windows api call) method (start the app using a file name as parameter),
then now the File-Append (Ctrl-A) does no longer work.  The menu item is grayed out (disabled).
version march 04 was ok, afterwards (march 13 and 14) not ok.
-
If i start the adm executable directly and load a file afterwards explicitely, then the File-Append menu item will be enabled.



eumagga0x2a

  • Hero Member
  • *****
  • Posts: 1379
Re: fixed: Menu access availabilty 2.6.18 / Qt5 2017/03/14
« Reply #12 on: March 14, 2017, 05:51:18 PM »
I hope this will be fixed once [UI] Fix menus not enabled if video was loaded on command line gets merged.

me444

  • Full Member
  • ***
  • Posts: 114
Re: fixed: Menu access availabilty 2.6.18 / Qt5 2017/03/14
« Reply #13 on: March 14, 2017, 05:57:13 PM »
Thanks for the info, eumagga0x2a !

me444

  • Full Member
  • ***
  • Posts: 114
Re: fixed: Menu access availabilty 2.6.18 / Qt5 2017/03/14
« Reply #14 on: March 15, 2017, 09:18:21 AM »
With the second build (#360) from mar 14 it appears to be fine again :)