2.6 patch for bitbuffer.h, C99 inline error with clang

Started by nibbles, March 04, 2012, 07:09:33 AM

Previous topic - Next topic

nibbles

llvm-gcc uses the 'inline' keyword as a optimization suggestion, but clang follows stricter C99.  This causes a compile error in twolame:

Here is the linker error: that I pasted into a gist

I made a patch with links and analysis here on github

and this is the raw p1 version of that patch, also on their site.

Okay thanks. (Last compile error with clang on osx!)     

nibbles

Hi!  Can I ping you on this?  I patched this way because it's my understanding compilers will inline short code segments by default.  So removing the inline keyword is harmless to other systems I hope.  I'm not sure if you saw this one I put here in patches....