build 'avidemux_core' with multithreading is broken

[sl1pkn07]

Hi

build 'avidemux_core' with multithreading (for example -j<more than 1>) is broken, make unrecognized files (bad linking?)

http://sl1pkn07.wtf/paste/view/f70f790c

tested with my double xeon x5650 (24threads)

with:

Code Select Expand

   
    git clone https://github.com/mean00/avidemux2.git avidemux
    mkdir -p buildcore
    cd build_core
    cmake ../avidemux/avidemux_core \
      -DFAKEROOT=fakeroot \
      -DCMAKE_INSTALL_PREFIX=/usr \
      -DCMAKE_BUILD_TYPE=Release
    make -j24 VERBOSE=""
    make VERBOSE="" DESTDIR="fakeroot" install


only works if set -j to 1 (one thread)

EDIT: also 'make install' with multithreading fails

greetings

[sl1pkn07]

anly notice of this?

greetings

[mean]

yes, that's why the boostrap script force -J 1
It's  a broken dependancy  somewhere

[sl1pkn07]

yep, in bootstrap set to -j1, but I use cmake comands directly instead a use boostrap (for make better split components for distro package maintainer)

all parts works ok (Qt5/Qt4/cli GUI and Qt4/Qt5/cli plugins, core plugins inclusive) with multithread mode except the avidemux_core part.

i think the failure is in ffmpeg build part (ffmpeg with autotools works ok, but not with avidemux cmake wrapper), but need more test

[sl1pkn07]

any fix for this?,

23 of my 24 threads machine they had become vague

greetings

[mean]

It should have been fixed

[sl1pkn07]

Code Select Expand


Scanning dependencies of target libpostproc
make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
[  0%] Built target libpostproc


[eumagga0x2a]

Code Select Expand

diff --git a/cmake/admFFmpegBuild.cmake b/cmake/admFFmpegBuild.cmake
index 2550360..81d346c 100644
--- a/cmake/admFFmpegBuild.cmake
+++ b/cmake/admFFmpegBuild.cmake
@@ -300,13 +300,10 @@ endif (FFMPEG_PERFORM_BUILD)
# Build FFmpeg
getFfmpegLibNames("${FFMPEG_SOURCE_DIR}")

-set(ffmpeg_gnumake_executable ${GNUMAKE_EXECUTABLE})
-convertPathToUnix(ffmpeg_gnumake_executable ${BASH_EXECUTABLE})
-configure_file("${AVIDEMUX_TOP_SOURCE_DIR}/cmake/ffmpeg_make.sh.cmake" "${FFMPEG_BINARY_DIR}/ffmpeg_make.sh")
registerFFmpeg("${FFMPEG_SOURCE_DIR}" "${FFMPEG_BINARY_DIR}" 0)

add_custom_target(                 libavutil_dummy
-    COMMAND ${BASH_EXECUTABLE} ffmpeg_make.sh
+    COMMAND $(MAKE)
                                    WORKING_DIRECTORY "${FFMPEG_BINARY_DIR}")
MACRO(FF_ADD_SUBLIB lib)
         add_custom_command(

allows parallel build for the bundled FFmpeg. I have not a slightest idea of far-reaching implications of skipping ffmpeg_make.sh.cmake though.

[mean]

win32 support i think, not sure, it was done by gruntster

[sl1pkn07]

perfect!

tnx bro!

[eumagga0x2a]

win32 support i think, not sure, it was done by gruntster

Could you please test if the suggested patch really breaks build on Windows? Because if it doesn't, it would be really nice to have it checked in as-is, maybe with a future follow-up for bootStrap.bash to take the actual number of CPU cores into account instead of hardcoded "-j 2". ffmpeg_make.sh.cmake would become redundant in this case.

TIA

[eumagga0x2a]

maybe with a future follow-up for bootStrap.bash to take the actual number of CPU cores into account instead of hardcoded "-j 2".

e.g.

Code Select Expand

diff --git a/bootStrap.bash b/bootStrap.bash
index d4ea659..ce67fa1 100644
--- a/bootStrap.bash
+++ b/bootStrap.bash
@@ -16,7 +16,8 @@ debug=0
qt_ext=Qt5
QT_FLAVOR="-DENABLE_QT5=True"
export QT_SELECT=5 # default for ubuntu, harmless for others
-export O_PARAL="-j 2"
+numcpucores=$(grep -c ^core /proc/cpuinfo)
+export O_PARAL="-j $numcpucores"
fail()
{
         echo "** Failed at $1**"

[sl1pkn07]

use 'nproc' instead for better num of cores detection

[Jan Gruuthuse]

Does that distinguish between real core and HT (intel). Quad core + 4 HT comes sometimes up as 8 core?

[sl1pkn07]

Code Select Expand


â”Å'â”â,¬Ã¢â€Â¤[$]|[sl1pkn07]|[sL1pKn07]|[~]|
â””â”â,¬Ã¢â€â,¬Ã¢â€â,¬Ã¢â€¢Â¼  grep -c ^core /proc/cpuinfo
24
â”Å'â”â,¬Ã¢â€Â¤[$]|[sl1pkn07]|[sL1pKn07]|[~]|
â””â”â,¬Ã¢â€â,¬Ã¢â€â,¬Ã¢â€¢Â¼  nproc
24


try yourself

my machine is a dual Xeon 6 cores with HT on