Checking for FAAD: faacDecInit NeAACDecInit

[Jan Gruuthuse]

- This is still working as intended by developers? switching from faacDecInit if not working to NeAACDecInit?
- getting this: (-DOLD_FAAD_PROTO) required with NeAACDecInit. Anything else to do?

-- Checking for FAAD
-- *****************
-- Found faad.h
-- Found faad library
-- Could not find faacDecInit in /usr/lib/x86_64-linux-gnu/libfaad.so
-- Change Dir: /home/jan/avidemux2/buildPluginsCommon/CMakeFiles/CMakeTmp

Run Build Command:"/usr/bin/make" "cmTC_fd3c8/fast"
/usr/bin/make -f CMakeFiles/cmTC_fd3c8.dir/build.make CMakeFiles/cmTC_fd3c8.dir/build
make[1]: Entering directory '/home/jan/avidemux2/buildPluginsCommon/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_fd3c8.dir/CheckFunctionExists.c.o
/usr/bin/cc -DCHECK_FUNCTION_EXISTS=faacDecInit  -fmessage-length=0 -fmessage-length=0    -I"/usr/include" -o CMakeFiles/cmTC_fd3c8.dir/CheckFunctionExists.c.o   -c /home/jan/avidemux2/install/usr/include/avidemux/2.7/cmake/cmake_compile_check/CheckFunctionExists.c
Linking C executable cmTC_fd3c8
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_fd3c8.dir/link.txt --verbose=1
/usr/bin/cc  -fmessage-length=0 -fmessage-length=0     -rdynamic CMakeFiles/cmTC_fd3c8.dir/CheckFunctionExists.c.o  -o cmTC_fd3c8 /usr/lib/x86_64-linux-gnu/libfaad.so
CMakeFiles/cmTC_fd3c8.dir/CheckFunctionExists.c.o: In function `main':
CheckFunctionExists.c:(.text+0x15): undefined reference to `faacDecInit'
collect2: error: ld returned 1 exit status
CMakeFiles/cmTC_fd3c8.dir/build.make:98: recipe for target 'cmTC_fd3c8' failed
make[1]: *** [cmTC_fd3c8] Error 1
make[1]: Leaving directory '/home/jan/avidemux2/buildPluginsCommon/CMakeFiles/CMakeTmp'
Makefile:126: recipe for target 'cmTC_fd3c8/fast' failed
make: *** [cmTC_fd3c8/fast] Error 2

-- Found NeAACDecInit in /usr/lib/x86_64-linux-gnu/libfaad.so
-- Found FAAD
-- Compiler Flags: /usr/include
-- Linker Flags  : /usr/lib/x86_64-linux-gnu/libfaad.so
-- (-DOLD_FAAD_PROTO) required

[eumagga0x2a]

AFAIR, there are two checks, one should succeed if libfaad-dev is installed and found, the other should fail.

If you haven't noticed, the faad audio decoder plugin is unused since the priority of the internal libavcodec for AAC has been increased. It hasn't been disabled completely to facilitate testing only.