Avidemux Forum

Avidemux => Main version 2.6 => Topic started by: mm0359 on August 19, 2016, 11:57:52 AM

Title: [cosmetic] Missing (yet expected) plugin "videoDecoders" (and others) directory
Post by: mm0359 on August 19, 2016, 11:57:52 AM
v2.6.13 on Windows Vista and "v2.6.13 + usp10.dll" on WinXP.
(A forum search finds older (like dated "2013") similar logs on Linux/MacOSX.)

"avidemux_cli.exe" reports:
{
[Script] Scanning directory ...\plugins\\scriptEngines/cli
[Script] Cannot parse plugin

[ADM_vd6_plugin] Scanning directory ...\plugins\\videoDecoders
[ADM_vd6_plugin] Cannot parse plugin

[ADM_ve6_plugin] Scanning directory ...\plugins\\videoEncoders/cli
[ADM_ve6_plugin] Cannot parse plugin
}

Actually, this plugin "videoDecoders" directory (and others) does not exist.

Issue : either install it as it should, and/or simply/explicitly detect/report it's not there.

***

Ftr, manually creating an empty directory "fixes" the error:
{
[ADM_vd6_plugin] Scanning directory ...\plugins\\videoDecoders
[ADM_vd6_plugin] Scanning done
}
Title: Re: Missing (yet expected) plugin "videoDecoders" directory
Post by: eumagga0x2a on August 19, 2016, 11:08:12 PM
"videoDecoders" directory should exist in "ADM_plugins6" as parent, not in "plugins" and contain a single decoder for vpx ("libADM_vd_vpx.so" on Linux).

The info about missing (https://github.com/mean00/avidemux2/blob/master/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoderInternal.h#L61) copyADM (https://github.com/mean00/avidemux2/blob/master/avidemux/common/ADM_videoEncoder/src/ADM_dynVideoEncoder.cpp#L144) is unrelated, I think.
Title: Re: Missing (yet expected) plugin "videoDecoders" directory
Post by: mm0359 on August 20, 2016, 04:16:15 PM
Quote from: eumagga0x2a on August 19, 2016, 11:08:12 PM
"videoDecoders" directory should exist in "ADM_plugins6" as parent, not in "plugins" and contain a single decoder for vpx ("libADM_vd_vpx.so" on Linux).
Could Linux and Windows be (a little) different?
Ftr, could you copy the related part of "avidemux_cli"(!?) log?

To confirm, there is no "libADM_vd_vpx.dll" installed on my WinXP.
Ah, this looks like a (cross-)compilation issue:
https://github.com/mean00/avidemux2/search?utf8=%E2%9C%93&q=videoDecoders (https://github.com/mean00/avidemux2/search?utf8=%E2%9C%93&q=videoDecoders)
avidemux/winInstaller/avidemux.nsi
${MementoSection} "VP8" SecVidDecVpx
${File} plugins\videoDecoders\libADM_vd_vpx.dll

avidemux/winInstaller/avidemux_cross.nsi
#${File} ${ADM_DIR}/plugins/videoDecoders/libADM_vd_vpx.dll

avidemux/winInstaller/avidemux_cross64.nsi
#${File} ${ADM_DIR}/plugins/videoDecoders/libADM_vd_vpx.dll


Then, this looks like 2 issues (at least on Windows):
1) Nicely support that the directory doesn't exist.
    (And/Or maybe create an empty one.)
2) Fix/Enable "libADM_vd_vpx.dll" cross-compilation/packaging.
    (Or document the situation, and possibly how to workaround it.)
Title: Re: Missing (yet expected) plugin "videoDecoders" directory
Post by: mean on August 20, 2016, 04:21:04 PM
1- I fail to see the problem. it tries to parse the folder, which may be empty or not exist at all. That's not an issue as far as i see it
If someone adds the relevant plugin, you just drop it in the folder and it works

2- libvpx is obsolete, recent versions of libavcodec can decode vp8/vp9 with no problem. So libvpx is no longer packaged, on purpose

Title: Re: [cosmetic] Missing (yet expected) plugin "videoDecoders" directory
Post by: mm0359 on August 20, 2016, 04:32:13 PM
Quote from: mean on August 20, 2016, 04:21:04 PM
1- I fail to see the problem. it tries to parse the folder, which may be empty or not exist at all. That's not an issue as far as i see it
If someone adds the relevant plugin, you just drop it in the folder and it works

2- libvpx is obsolete, recent versions of libavcodec can decode vp8/vp9 with no problem. So libvpx is no longer packaged, on purpose

1- The "cosmetic" issue is the "[ADM_vd6_plugin] Cannot parse plugin" error.

2- Good to know. Fine then.
Title: Re: Missing (yet expected) plugin "videoDecoders" directory
Post by: eumagga0x2a on August 20, 2016, 05:59:08 PM
Quote from: mean on August 20, 2016, 04:21:04 PM2- libvpx is obsolete, recent versions of libavcodec can decode vp8/vp9 with no problem. So libvpx is no longer packaged, on purpose

I am a bit concerned about communication in and around the project. This essential info would have been valuable in http://avidemux.org/smif/index.php/topic,17015.0.html (http://avidemux.org/smif/index.php/topic,17015.0.html). Confirming that deleting or not building the ancient Avidemux vpx decoder plugin fixes the swapped U/V issue with VP8 videos.

Please kill this plugin for good then! At least don't build it.

diff --git a/avidemux_plugins/ADM_videoDecoder/CMakeLists.txt b/avidemux_plugins/ADM_videoDecoder/CMakeLists.txt
index 9586aff..e953354 100644
--- a/avidemux_plugins/ADM_videoDecoder/CMakeLists.txt
+++ b/avidemux_plugins/ADM_videoDecoder/CMakeLists.txt
@@ -1 +1 @@
-ADD_SUBDIRECTORY(vpx)
+#ADD_SUBDIRECTORY(vpx)


I get the harmless info message

[ADM_vd6_plugin] Scanning directory /usr/local/lib64/ADM_plugins6//videoDecoders
[ADM_vd6_plugin] Cannot parse plugin


then too (with double slash when built without the patch from http://avidemux.org/smif/index.php/topic,17026.msg76374.html#msg76374 (http://avidemux.org/smif/index.php/topic,17026.msg76374.html#msg76374)), no matter which Avidemux frontend I use.
Title: Re: Missing (yet expected) plugin "videoDecoders" directory
Post by: mm0359 on August 20, 2016, 10:23:12 PM
Quote from: eumagga0x2a on August 19, 2016, 11:08:12 PM
The info about missing copyADM is unrelated, I think.
Thanks.
I moved it to this copyADM (http://avidemux.org/smif/index.php/topic,10787.msg76420.html#msg76420) topic