Partial again ^^
- When previewing the video (main window, 'play filtered') the partial filters are applied at the wrong times, previewing doesn't take the current timer slider position into account.
eg partial filter from 20sec to 30sec:
- when playing the video from the beginning, timing is right
- when starting playback at 40mins, the filter is shown from 40:20 to 40:30
- preview window inside a partialized filter is broken:
- make a filter partial
- open partial configuration (time codes) by double-clicking the partial filter
- click on 'Configure filter' => no preview available, not even at times where partial is defined/ configured to
Quote from: eumagga0x2a on May 20, 2017, 05:57:46 PM
reordering partialized filters doesn't rescale the start and end time if a filter in the stack modifies the total duration.
You should add that reordering partialized filters doesn't rescale the start and end time if a filter in the stack modifies the total duration.
*adds eumagga0x2a's bug*
sorry, never had that one occuring, because I didn't have to use any time-changing filters so far
Quote from: p3trus on May 19, 2017, 11:33:48 AM
- make a filter partial
- open partial configuration (time codes) by double-clicking the partial filter
- click on 'Configure filter' => no preview available, not even at times where partial is defined/ configured to
What actually should happen when calling configure for the partialized (son) filter from the partial filter configure dialog, if the former has a seekable preview? Should the preview behave exactly as if the filter was never partialized?
Either that (would most likely be easier to implement), or seeking restricted to the range of the partial filter (scaled up to the whole length of the seek bar) - the latter would give more control in some cases, eg applying a delogo filter on a moving in & out info logo of a recording - the seeking steps of the normal (filter) preview are quite big.
The seekable preview within partialized filters should be fixed (https://github.com/mean00/avidemux2/commit/62ed4cf8babd6f9f131e00a9ac4cbfa33847bf66) now.
I agree that available seek steps in the preview leave room for improvement.