Avidemux Forum

Avidemux => Main version 2.6 => Topic started by: eumagga0x2a on December 24, 2016, 09:00:35 PM

Title: Cross-build failure related to moving flyDialog to Qt
Post by: eumagga0x2a on December 24, 2016, 09:00:35 PM
Merry Christmas!

I'm working on making UI_updateDrawWindowSize take into account the actual width of the codec widget area instead of a constant, arbitrary margin (well, I can't get rid of an arbitrary margin completely, but it works much better with different font sizes and different translations now). While trying to test my changes on Windows, I ran into a probably already known issue: cross-compiling Avidemux as of [flyDialog] simplify more (https://github.com/mean00/avidemux2/commit/d2b749f2da5e5b4f06d83c18ed33753625380a7c) fails currently with

error: 'ADM_flyDialog::ADM_flyDialog(uint32_t, uint32_t, ADM_coreVideoFilter*, ADM_QCanvas*, QSlider*, ResizeMethod)' redeclared without dllimport attribute: previous dllimport ignored [-Werror=attributes]
   ADM_flyDialog::ADM_flyDialog(uint32_t width, uint32_t height, ADM_coreVideoFilter *in,
   ^


for ADM_flyDialog::ADM_flyDialog and similarly for every function defined in T_flyDialogQt4.cpp.

A native build succeeds.
Title: Re: Cross-build failure related to moving flyDialog to Qt
Post by: mean on December 24, 2016, 09:49:04 PM
Thanks for the info
Probably again the pure functions not exportable through dll

Title: Re: Cross-build failure related to moving flyDialog to Qt
Post by: mean on December 24, 2016, 10:07:32 PM
ah no
Should be okay now
Title: Re: Cross-build failure related to moving flyDialog to Qt
Post by: eumagga0x2a on December 24, 2016, 11:06:36 PM
Yes, fixed by [flyDialog] proper export (https://github.com/mean00/avidemux2/commit/5c8664c5da4fbf2c3f1922b3cfcab8e216e19331), thank you very much.