Avidemux Forum

Participate => Patch gallery => Topic started by: nibbles on March 04, 2012, 07:09:33 AM

Title: 2.6 patch for bitbuffer.h, C99 inline error with clang
Post by: nibbles on March 04, 2012, 07:09:33 AM
llvm-gcc uses the 'inline' keyword as a optimization suggestion, but clang follows stricter C99.  This causes a compile error in twolame:

Here is the linker error: that I pasted into a gist (https://raw.github.com/gist/1971078)

I made a patch with links and analysis here on github (https://github.com/2bits/patches/commit/bdcd590dc77b05e55017afb345e856b8c7afac0d)

and this is the raw p1 version of that patch, also on their site. (https://github.com/2bits/patches/raw/bdcd590dc77b05e55017afb345e856b8c7afac0d/26r7745.bitbuffer.h.diff)

Okay thanks. (Last compile error with clang on osx!)     
Title: Re: 2.6 patch for bitbuffer.h, C99 inline error with clang
Post by: nibbles on March 19, 2012, 08:51:49 PM
Hi!  Can I ping you on this?  I patched this way because it's my understanding compilers will inline short code segments by default.  So removing the inline keyword is harmless to other systems I hope.  I'm not sure if you saw this one I put here in patches....