Avidemux Forum

Avidemux => Windows => Topic started by: mm0359 on August 19, 2016, 12:08:23 PM

Title: [cosmetic] "avidemux_cli.exe": doubled '\' after "...\plugins"
Post by: mm0359 on August 19, 2016, 12:08:23 PM
"v2.6.13 + usp10.dll" on WinXP.

"avidemux_cli.exe" reports (55) lines like:
{
[Script] Scanning directory ...\plugins\\scriptEngines
...
[ADM_ad_plugin] Scanning directory ...\plugins\\audioDecoder
...
}

Notice the needlessly doubled '\'.
Should be simple to merge/suppress.
Title: Re: "avidemux_cli.exe": doubled '\' after "...\plugins"
Post by: eumagga0x2a on August 19, 2016, 10:35:21 PM
A duplicated folder level separator seems to originate from https://github.com/mean00/avidemux2/blob/master/avidemux_core/ADM_core/src/ADM_fileio.cpp#L364 (https://github.com/mean00/avidemux2/blob/master/avidemux_core/ADM_core/src/ADM_fileio.cpp#L364)

diff --git a/avidemux_core/ADM_core/src/ADM_fileio.cpp b/avidemux_core/ADM_core/src/ADM_fileio.cpp
index 1b9b134..3a4c73b 100644
--- a/avidemux_core/ADM_core/src/ADM_fileio.cpp
+++ b/avidemux_core/ADM_core/src/ADM_fileio.cpp
@@ -361,7 +361,7 @@ std::string ADM_getPluginDir(const char *subfolder)
             pluginDir = std::string(p);
             delete [] p;p=NULL;
     }
-    return pluginDir+std::string(ADM_SEPARATOR)+std::string(subfolder);
+    return pluginDir+std::string(subfolder);
}           

// EOF


fixes this at least on Linux.
Title: Re: "avidemux_cli.exe": doubled '\' after "...\plugins"
Post by: mean on August 20, 2016, 06:01:03 AM
It is purely cosmetic, harmless
Title: Re: "avidemux_cli.exe": doubled '\' after "...\plugins"
Post by: mm0359 on August 20, 2016, 09:23:24 PM
Quote from: mean on August 20, 2016, 06:01:03 AM
It is purely cosmetic, harmless
Agreed. Though nice to have out of the way.