Avidemux Forum

Avidemux => Windows => Topic started by: mm0359 on August 23, 2016, 12:48:56 AM

Title: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 23, 2016, 12:48:56 AM
"v2.6.13 + usp10.dll" on WinXP and v2.6.13 on WinVista.

%avidemux_cli% --load "LoadTst.ts" --quit

0: ...\avidemux_cli.exe
1: --load
2: LoadTst.ts
3: --quit

...

load-->1
EXCEPTION_ACCESS_VIOLATION
ADM_Composer::addFile(char const*)  [avidemux_cli.exe]


Ftr, already having a .ts.idx2 doesn't help.
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 23, 2016, 06:17:52 AM
On WinXP, (usp10.dll doesn't matter to avidemux_cli.exe)
And same results on WinVista.

v2.6.8v2 works fine.

v2.6.9v2 + usp10.dll,
v2.6.10 + usp10.dll,
v2.6.11 + usp10.dll:

...
Compiler: GCC 4.8.3
...

load-->1


Crash since v2.6.9v2, though not reported.

v2.6.12 + usp10.dll:
load-->1
EXCEPTION_ACCESS_VIOLATION
ADM_Composer::addFile(char const*)  [avidemux_cli.exe]
Cleaning up
[deleteAll] [Editor] Deleting all videos
[deleteAll] [Editor] Deleting all videos
[deleteAll] [Editor] Deleting all videos
[Script] Tinypy INFO - Closing Python
[destroy] Destroying preview
[ADM_ad_cleanup] Purging audio decoder
[ADM_vf_clearFilters] clear filters
[ADM_vf_cleanup] Destroying video filter list
--End of cleanup--

Images stat:
___________
Max memory consumed (MB)     : 0
Current memory consumed (MB) : 0
Max image used               : 0
Cur image used               : 0
[onexit]
Goodbye...

v2.6.12: Crash reported, then cleanup.

1- Crash started between v2.6.8v2 ("2014-03-23") and v2.6.9v2 ("2015-05-16").
2- Is it intended that v2.6.13 doesn't cleanup, unlike v2.6.12?
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 23, 2016, 09:19:29 AM
Quote from: mm0359 on August 23, 2016, 06:17:52 AM
On WinXP, (usp10.dll doesn't matter to avidemux_cli.exe)

2- Is it intended that v2.6.13 doesn't cleanup, unlike v2.6.12?

Fwiw, avidemux_r230816_win32Qt5.7z nightly (http://www.avidemux.org/nightly/win32/) seems to have improved/fixed that:
  Avidemux v2.6.13 (160823_db82935b565) .

load-->1
EXCEPTION_ACCESS_VIOLATION
ADM_Composer::addFile(char const*)  [avidemux_cli.exe]
[abortExitHandler] already done, nothing to do
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 23, 2016, 11:19:01 PM
Quote from: mm0359 on August 23, 2016, 06:17:52 AM
On WinXP, (usp10.dll doesn't matter to avidemux_cli.exe)
v2.6.11 + usp10.dll:
...
load-->1

Crash since v2.6.9v2, though not reported.

Ftr,
"v2.6.11 (160210_f4e7b7ff081) Debug + usp10.dll" on WinXP,
doesn't report either.
And same result on WinVista.
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 25, 2016, 10:59:58 PM
Quote from: mm0359 on August 23, 2016, 09:19:29 AM
  Avidemux v2.6.13 (160823_db82935b565) .

load-->1
EXCEPTION_ACCESS_VIOLATION
ADM_Composer::addFile(char const*)  [avidemux_cli.exe]
[abortExitHandler] already done, nothing to do


"v2.6.13 (160825_dbff7c1aee7) Debug" on WinVista
reports the same.
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 26, 2016, 12:20:28 AM
"v2.6.13 (160825_dbff7c1aee7) Debug" on WinVista.

Opens + reads (4 KB) + closes LoadTst.ts,
then immediately crashes!

SysInternals Process Monitor

...
01:51:26,8502121 avidemux_cli.exe 6068 CreateFile ...\LoadTst.ts SUCCESS Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, AllocationSize: n/a, OpenResult: Opened
01:51:26,8504507 avidemux_cli.exe 6068 ReadFile ...\LoadTst.ts SUCCESS Offset: 0, Length: 4 096, Priority: Normal
01:51:26,8505113 avidemux_cli.exe 6068 CloseFile ...\LoadTst.ts SUCCESS
01:51:26,8506109 avidemux_cli.exe 6068 QueryNameInformationFile ...\libADM_core6.dll SUCCESS Name: ...\libADM_core6.dll
01:51:26,8510827 avidemux_cli.exe 6068 CreateFile ....\dbghelp.dll SUCCESS Desired Access: Read Attributes, Disposition: Open, Options: Open Reparse Point, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: Opened
...

"CloseFile" stack:

...
17 libADM_core6.dll ADM_fclose + 0x11 0x65544380 ...\libADM_core6.dll
18 avidemux_cli.exe Z11A_openVideoPKc + 0xd5 0x402a85 ...\avidemux_cli.exe
19 avidemux_cli.exe ZN20ADM_videoFilterQueueC1EP19ADM_coreVideoFilterP10CONFcouple + 0x8b1 0x43ea91 ...\avidemux_cli.exe
20 avidemux_cli.exe Z10automationv + 0x3ed 0x43f45d ...\avidemux_cli.exe
21 avidemux_cli.exe Z9UI_RunAppv + 0x11 0x43f711 ...\avidemux_cli.exe
22 avidemux_cli.exe SDL_main + 0x48 0x40c9f8 ...\avidemux_cli.exe
23 avidemux_cli.exe avidemux_cli.exe + 0x13de 0x4013de ...\avidemux_cli.exe
...
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 26, 2016, 02:08:53 AM
Quote from: mm0359 on August 23, 2016, 06:17:52 AM
And same results on WinVista.

v2.6.8v2 works fine.

Working log is:

...
Compiler: GCC 4.7.2
...
load-->1
[TS Demuxer] Probing...
[checkMarker] [Ts Demuxer] Sync ok :5577 Sync ko :0
[detectTs] [TS Demuxer] 188 bytes packet detected
[TS Demuxer] There is an index for that file
[flvHeader] Cannot open that
[mkvHeader] Cannot open that
[MP4] Cannot open that...
[mxfHeader] Cannot open that (1cda0747)
[openDML] Cannot open that
[picHeader] Cannot open that
[asfHeader] Cannot open that
match :189 / 455 (probeSize:1048576)
[PS Demuxer] There is an index for that file
[psDemux] Incorrect or not found type
[tsDemux] Append=0

Simple loading:
file: ...\LoadTst.ts, size: 259048020
found 1 files
Done
...


(v2.6.9v2 and) v2.6.13-Debug crashes, even without the plugins directory:
likely in (core)

avidemux/common/ADM_editor/src/ADM_edit.cpp

bool ADM_Composer::addFile (const char *name)

// First find the demuxer....
video._aviheader=ADM_demuxerSpawn(magic,name);


avidemux_core/ADM_coreDemuxer/src/ADM_dynaDemuxer.cpp

vidHeader *ADM_demuxerSpawn(uint32_t magic,const char *name)

Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mean on August 26, 2016, 05:16:44 AM
Might be a compiler issue, i had similar problem on win64
but the updating process is more complicated on win32
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 26, 2016, 05:04:11 PM
Quote from: mean on August 26, 2016, 05:16:44 AM
Might be a compiler issue, i had similar problem on win64
but the updating process is more complicated on win32

Good to know.
I hope you can manage to confirm/update.
Maybe some "compiler flags" could workaround this in the meantime?
Let me know if I can help (testing locally, not compiling).
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 28, 2016, 11:20:12 PM
Quote from: mean on August 26, 2016, 05:16:44 AM
Might be a compiler issue

On WinXP,
avidemux_2.6.13_r160827_win32.exe nightly (http://www.avidemux.org/nightly/win32/)
which includes
[build] Tweak Cross compiler to support both gcc and clang. It is mesââ,¬Â¦ (https://github.com/mean00/avidemux2/commit/81af565150fe097918e5d5ec6d4ee33e38a553a6)
would fix this.

  Avidemux v2.6.13 (160827_3bbe49d1383) .
  Avidemux v2.6.13 (160828_bc4c29c4e69) .

...
Compiler: GCC 4.2.1 Compatible Clang 3.8.0 (tags/RELEASE_380/final)
...
Normal exit
[abortExitHandler] already done, nothing to do
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 29, 2016, 01:42:00 AM
[Core] Tweak SSE removal for clang/win32 (https://github.com/mean00/avidemux2/commit/e6ed0474814aa0ec55caa78e45924681c546cac9)
is better, but still wrong.

...
[cpuCaps]Checking CPU capabilities
MMX detected
MMXEXT detected
SSE detected
SSE2 detected
[cpuCaps]End of CPU capabilities check (cpuMask :ffffffff, cpuCaps :6)
[setMask] [CpuCaps] Setting mask to 0xfffffff
...


Fixed by
[Build] Revert disabled sse with clang (https://github.com/mean00/avidemux2/commit/df48d436099416cf58bc6006b73c6a1b129d7d65)
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 29, 2016, 11:21:18 PM
On WinXP,
avidemux_2.6.13_r160829_win32.exe nightly (http://www.avidemux.org/nightly/win32/)
which includes
[build] Some mxe fixes  (https://github.com/mean00/avidemux2/commit/2c87e30cc140506922c9cda8e886e6930401a633)
would fix this.

  Avidemux v2.6.13 (160829_5aae1af1f9e) .

...
Compiler: GCC 4.9.4
...
Normal exit
[abortExitHandler] already done, nothing to do
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mean on August 31, 2016, 03:24:51 PM
do you stll need the ups dll ?
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on August 31, 2016, 11:12:04 PM
Quote from: mean on August 31, 2016, 03:24:51 PM
do you stll need the ups dll ?

On WinXP (only),
usp10.dll needed:
*2.6.8: no.
*2.6.9 - 2.6.13_r160823: yes.
*2.6.13_r160827 - 2.6.13_r160828, (clang): yes.
*2.6.13_r160829 - 2.6.13_r160901 (new mxe): no.

On WinXP and WinVista,
libx265_xp.zip needed:
*2.6.8: N/A.
*2.6.9 - 2.6.12: no.
*2.6.13 - 2.6.13_r160823: yes.
*2.6.13_r160827, (clang): yes.
*2.6.13_r160828, (clang): no.
*2.6.13_r160829 - 2.6.13_r160901 (new mxe): no.

These 2 (win32) dll issues are fixed.
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mean on September 02, 2016, 06:39:57 AM
thx
Title: Re: EXCEPTION_ACCESS_VIOLATION in ADM_Composer::addFile(...) [avidemux_cli.exe]
Post by: mm0359 on October 31, 2016, 07:17:26 PM
Quote from: mm0359 on August 29, 2016, 01:42:00 AM
[Build] Revert disabled sse with clang (https://github.com/mean00/avidemux2/commit/df48d436099416cf58bc6006b73c6a1b129d7d65)

+ (cosmetic)
ADM_cpuCap.cpp : improve cosmetic for cpuCaps and cpuMask. (https://github.com/mean00/avidemux2/commit/ad962a343ba861ea5337099837deb2086623d004)
Merge pull request #22 from mm1044/mm1044-ADM_cpuCap_cpp-myCpuCaps (https://github.com/mean00/avidemux2/commit/2897fd15327906b1dcb7cd818690f622b5ca12b8)

I assume getMask() and setMask() (https://github.com/mean00/avidemux2/search?utf8=%E2%9C%93&q=getMask+setMask&type=Code) calls are good as they are...