Avidemux Forum

Avidemux => Main version 2.6 => Topic started by: Danette on March 17, 2018, 03:39:26 PM

Title: 2.7 (and 2.6) Crash With YV12 & HuffYUV Encoders
Post by: Danette on March 17, 2018, 03:39:26 PM
Editing and converting a VOB file results in a crash every time. Output: YV12 Encoder, audio is copy and format is an AVI container. Same thing happens with the (FF)HuffYUV encoder. Copy works fine.

VirtualDUB processes the same VOB file like a champ.

Log file attached. I've removed hundreds of the
Quote[getPacket] 15:25:28-804 [PerfectAudio]Warning skew of 51000 us
lines to save space.
Title: Re: 2.7 (and 2.6) Crash With YV12 & HuffYUV Encoders
Post by: eumagga0x2a on March 17, 2018, 04:41:35 PM
As the crash in AVI muxer doesn't occur with short (a few minutes long) samples and I don't have storage for longer ones at the moment, could you please find out how long the sample must be to trigger the crash?
Title: Re: 2.7 (and 2.6) Crash With YV12 & HuffYUV Encoders
Post by: Danette on March 17, 2018, 04:59:23 PM
At about 4 minutes, 30 seconds.
Title: Re: 2.7 (and 2.6) Crash With YV12 & HuffYUV Encoders
Post by: eumagga0x2a on March 18, 2018, 12:43:32 AM
Thank you. To avoid the crash, please select "OPENDML" as muxing format in the configuration of the AVI muxer.  The default option "AUTO" doesn't do what one would expect and always chooses the legacy format ("Avi"), unsuitable for large (>2 GiB) AVI files.
Title: Re: 2.7 (and 2.6) Crash With YV12 & HuffYUV Encoders
Post by: Danette on March 18, 2018, 05:12:29 PM
Yes, that worked. Thank you. Seems like a bug fix might be in order.
Title: Re: 2.7 (and 2.6) Crash With YV12 & HuffYUV Encoders
Post by: eumagga0x2a on March 19, 2018, 05:20:02 PM
After a closer look at the code, the crash seems to happen due to uninitialized use of a variable in the process of switching from the legacy AVI to OpenDML format shortly before the 4 GiB (not 2 GiB, sorry) limit is reached (the AUTO is really exactly the same thing as "Avi", both try to switch to OpenDML near the critical size).
Title: Re: 2.7 (and 2.6) Crash With YV12 & HuffYUV Encoders
Post by: eumagga0x2a on March 20, 2018, 08:08:03 PM
Should be fixed by [muxerAvi] Initialize baseOffset when switching to OpenDML format (https://github.com/mean00/avidemux2/commit/82c3293db73ff761ef5612e68b90c975832bb72c), thank you for your report.