Hi guys,
I'am using Avidemux and I have some question / requests about it.
1.) Why is there no fullscreen option? I know you said Avidemux is no player but I think thats not the point. If I did edit my video then I would like to preview it first or just any parts of it. Otherwise the zoom option keys 1-4 are not really a help.
2.) What about the click-able function icons right under the menu. There are just 4 icons I can click and the rest of that bar is empty. How to customize that bar with more functions to prevent using the menu / shortcuts? I would like to have an close icon button to close any loaded media without using menu / SC. How to add another buttons?
3.) Would be nice if you could add a option in settings to load a new file as new file itself without to append it each time if I drag & drop a file into Avidemux so this is really annoying specially if you have to edit / cut many files one by one.
4.) Logo Filter. Could you add also negative X & X values? I see I can not move the logo more to left side & top because the minimum value are 0 unfortunately. In some cases I need to move the logo a little out of the visible area. The same I can do for the right side & bottom what is good but I also need the same possibility for left side & top. Would be nice if you could add this too.
5.) Active Filter Preview / Selected filter preview. There is a problem with the added filter layers. Just a example, if I add a Color Balance filter first and a second filter (LOGO) on position 2 in the list and select the last filter in the list and press preview then it does preview all filters together what is ok so far. The problem is why it can not preview the Color Balance & LOGO filter together in filter mode? In some cases I need to see both (or all) filter together with the chance to change the Color Balance value of video layer only and adjust them with the LOGO layer colors. I just can set the LOGO filter at position 1 and Color filter at position 2 and then I double click on CB filter and I see both together but also both will changed (in preview) and the LOGO filter changes too whats the problem. So I wanna see both at the same time but just wanna edit / change coler of the video only and not the LOGO. Can you change that?
6.) Is there no play function for the marked area only? Also no loop play for that too?
7.) I'am using the latest version 2.8.2 and see that my mouse-pointer icon does change when I seek the slider for or backward (round loading icon). Is that normal now in this version?
So I hope I did not forget any question to ask so far and I hope you guys don't mind about asking them. :)
Thank you
1. Exactly, not a video player, therefore no need for fullscreen from my POV. However, an ability to inspect all areas of the picture even on small screens and at high zoom levels is sorely missed.
Quote from: Silox on February 21, 2023, 08:28:39 PMHow to customize that bar with more functions to prevent using the menu / shortcuts?
IMHO nothing can even remotely compete with keyboard shortcuts for using an application efficiently. Especially the Ctrl+W (Command+W on macOS) shortcut is very comfortable as far as a keyboard is attached. However, I do think that a toolbar button to run a user-configurable script might be very useful (scripts cannot close a video ATM, however).
Regarding 4, it would require some changes in the core and break compatibility with existing addLogo configurations (i.e. with existing project scripts), but maybe.
Could you please rephrase 5 so that my foggy mind can follow?
Quote from: Silox on February 21, 2023, 08:28:39 PMThe problem is why it can not preview the Color Balance & LOGO filter together in filter mode?
I don't really get what you mean by "filter mode". We have on-the-fly previews in configuration dialogs of many video filters, we have a preview function in the filter manager which displays the output of the entire chain of enabled filters up to the selected one (you can temporarily disable filters in the chain) and we can also preview the output of the complete filter chain in the main window.
To 6: No. I am not enthusiastic about adding this capability as seeking back to the start of a selection can take a huge amount of time depending on video stream properties, availability of hardware-accelerated decoding and on post-processing.
To 7: yes, it is a feature. Depending on video codec, resolution and post-processing (especially tone-mapping for HDR sources), even decoding a keyframe can take a lot of time and visual feedback is needed.
Hello eumagga0x2a,
thanks for your answer.
So I think a fullscreen option would be very welcome for all of us. Maybe you can think about it one more time.
About keyboard shortcuts you mention as very comfortable, maybe just for poeple who like to work with shortcuts but many do not. Otherwise, what about persons with an handicap who can not using the keyboard comfortable? Adding more buttons for shortcuts would be welcome too to save unnecessary detours. All basic functions should also have buttons and not just shortcuts, otherwise you could also remove all existing buttons you know. Just let the user decide. In my case I would like to have buttons to prevent detours. So in the button bar are just four buttons so let us use the free area too (optional).
About the LOGO. Just check this out and try to add the neg values for X & Y. Would be good if you could do that.
About point 5. As I said, its only possible to preview all filters at once by selecting the last filter in the filter-list and press preview and in this case I see the final result what is OK so far. What I'am talking about is that its not possible to preview all active filters at once and JUST to edit / change only any selected filter.
Example: Load any video, then enable filter, pick any filter like color temp as first filter, then pick second filter LOGO and load any tiny image. Now you got the color filter as first one and the LOGO filter as second filter = 2 layers. This order means that the color filter on position 1 does not affect the image in the LOGO filter which is set after color filter on position 2 = OK. Now, I want to preview both filters at same time in edit mode but this is not possible. When I doubeclick on first filter / color then it does not show any other filters on the preview image, its just showing the color filter alone for the video. If I doubleclick the second filter (LOGO) then it does show all filters in action. So what I mean is (hard to explain), I need to preview all filters at once which are active BUT I only want to see the filter changes of the video only and NOT of the LOGO. Do you know what I mean?
1.) Temp color filter
2.) Logo filter with any logo image etc
Now doubleclick the first temp color filter and now you just see the video itself in preview window but not Logo filter image. If you doubleclick on LOGO filter then the preview window shows the video with changed color of filter from position 1. But it is not possible to let show all filter in a preview + choosing one filter to edit the video only and let un-changed the view of the others. I made some images showing the problem and showing how it works when using VirtualDub2.
(https://i.postimg.cc/mgWJ98Yh/T1-2023-02-22-015800.png)
Next image below...
(https://i.postimg.cc/YSDwQQ2V/T2-2023-02-22-015800.png)
Next image / working in VD2...
(https://i.postimg.cc/J45vbjPq/T3-2023-02-22-015800.png)
...
So is it clear now what I mean? :) So what you should do is that you need to show all active filters in the single preview windows of the filters itself WITHOUT to change anything except the video image. In the last image you can see that, I do change the color value to yellow/ish and it does only affect the video image layer and not the logo image which keeps gray. In this case I can adjust colors of video itself and seeing the original logo image what does not change = Good. Somehow this method is not doable in Avidemux yet and thats a pity. I just wanna change the color of video only + seeing my logo image at the same time what should keep unchanged. Maybe you can make it work to preview all filters at once and just edit the selected one only.
Quote from: Silox on February 22, 2023, 01:44:43 AMSo is it clear now what I mean?
Yes, thank you for this perfectly executed presentation. You wish to have filter controls accessible while in preview in the filter manager. This would IMHO require a full rewrite of the latter and of all filter GUIs in Avidemux. If you are interested, feel free to submit patches, I don't have time and motivation to work on it.
Regarding a dedicated close button for currently loaded video, this won't work nicely in an application like Avidemux which resizes its GUI depending on loaded video (you click and the window is yanked from below the mouse pointer). In some sense, the open video toolbar button is already a close button as opening a video using this icon will close the currently loaded one. Something along the lines of a custom script toolbar button with scripting gaining ability to close a video might make sense, IMHO.
Redesigning the toolbar and making important functionality, currently hiding in submenus, easier accessible looks indeed like a valid goal.
Quote from: eumagga0x2a on February 21, 2023, 11:42:50 PMIMHO nothing can even remotely compete with keyboard shortcuts for using an application efficiently. Especially the Ctrl+W (Command+W on macOS) shortcut is very comfortable as far as a keyboard is attached. However, I do think that a toolbar button to run a user-configurable script might be very useful (scripts cannot close a video ATM, however).
Keyboard shortcuts are great for people with excellent memories. However, not all of us are blessed with that kind of memory. Personally I NEVER use keyboard shortcuts for anything other than cutting and pasting text - seriously, in over 30 years of using computers the only keyboard shortcuts I can remember well enough to use regularly are Control-C, Control-V, and Control-X (and their Command- equivalents in MacOS). And that's it. For EVERYTHING else I do point and click. If my mouse stops working I am unable to use my computer until I get a replacement and I can't even shut the computer down cleanly.
This is also why I don't do programming - I can't remember the various commands and what they do. It sometimes takes me hours to write even a short bash script because I have to look up every single command I need to use and figure out how to use it. Now I find ChatGPT can write those short scripts in seconds if I can just give a good description of what I want the script to do, and often the script it produces actually works! But I digress, but anyway I cannot fathom how anyone can remember a bunch of keyboard shortcuts, because I sure can't, and I suspect I am far from the only one. I would posit that most programmers and developers have much better memories (maybe bordering on photographic) than the average person.
Hi again,
hmmm, what a great answer eumagga0x2a! As I see you are not willing to change / add anything of my ideas / requests also not some simple thing like adding another button and connect this with the already present CLOSE file function? You just need to add a button into resources and write few lines at WM_COMMAND message and thats it. Just remember the old ADM versions like 2.5.0 what also had more buttons (11) in the tool bar. So I don't see any problem by adding another buttons. Otherwise, if you don't wanna add a another button for the close file function then it would be also fine if you would add another checkbox in the settings in first tab under "check for updates" you can set another checkbox called "Enable Close File on Drag & Drop". Just let this new option unchecked in default mode and people like me can check that option who prefer a direct unload of the old file during a new drag and drop operation. In this case you don't need to add another button.
Quote from: eumagga0x2a on February 22, 2023, 10:32:17 PMIn some sense, the open video toolbar button is already a close button as opening a video using this icon will close the currently loaded one.
Is that a joke? Most of us using drag & drop function and not the open button to pick any file. We all are looking for good tools which also present a good handling (user-friendly) but somehow you don't see this like me what is really pitty. Also the idea not to implement a simple fullscreen mode is total not comprehensible but adding a strange ZOOM view mode which works pretty bad (there is no sense to zoom into the left top corner of the video @1) seems to be more important for you. Even to play just the selected video part is not possible. There are missing few basic functions in your app which would make ADM to a better editor you know. But anyway, its not the first time I meet some strange thinking coding guys. :) All in all its just a pitty (for us all) as I said already.
PS: Maybe one hint for the future. Think forward.
Drag&drop will attempt to append multiple segments. you can use CTRL+W to close the currently open video or use the toolbar open icon to close the current video and load a new one.
+1 to the idea of adding a new customizable button in the toolbar.
Quote from: butterw on February 24, 2023, 06:12:18 PMDrag&drop will attempt to append multiple segments. you can use CTRL+W to close the currently open video or use the toolbar open icon to close the current video and load a new one.
So this is the problem what I was talking about already in my pre posts. I don't wanna attempt another files when using drag & drop function. I always have to use the menu itself to choose the "close" entry or using CTRL+W = detour. Also using the OPEN icon in toolbar does not close the file except I choose another file to load = detour. Lets say you wanna check different video files from diffrent sources and most of us using filemanger tools or just Explorer itself you do see already all video files and then you just pick the file you want and drag & drop it into the app. In case of ADM you always have to close the file first before you drag next file into or otherwise you get a error message if the file does not match with the video datas of the first loaded video. Thats just a nonsensical. On a fresh drag / drop I do normally expect a single load with an unload of the old file and no append operation. In the menu you see already a Append menu entry (2) Strg+A you can choose when you need it. Also here, in most cases user do edit single videos and not videos to append which is more the exception. I will give you a another example to understand what I mean about simple & fast & user-friendly handling what is the A&O. Just open your explorer any folder with some videos you wanna check. Now start any video-player (VLC) and move it next to the visible file-list. Now you can just drag / drop any video into the player app to play it right away and then drag / drop next one and so on. On that way you can check videos quickly without to unload any video or open the filemenu to pick a other video etc what is total waste of time and detour = Not User-Friendly. Somehow you guys do not think in all possible directions to make specific processes simple and save unnecessary detours. Also using shortcuts is not always a good alternative because some of us don't like it or just can't use it you know. ADM is not a new tool and simple things like that should be added already a long time ago so that makes me wonder why its not happend already in the past. Some things are just pretty simple and obvious. Not sure whether I'am the only one who is seeing it like that. You always have to give the user the possibility to choose (if possible) without to force them to go into specific given direction. If you can make function & methods simplify without much effort then just do it to increase the User friendliness = Thumbs up!
In the case of a single selected video, Drag&Drop clean opening the new video makes more sense IMO than Appending to the current one. But that's not the way Avidemux has worked so far. Also Avidemux lacks a proper user configuration file, so currently adding many new user preferences isn't practical.
Avidemux just needs an extra developper who understands GUIs to contribute the required improvements...
Quote from: butterw on February 25, 2023, 02:25:49 PMIn the case of a single selected video, Drag&Drop clean opening the new video makes more sense IMO than Appending to the current one. But that's not the way Avidemux has worked so far.
That's the problem. The app is just much limited for the user to make own basic / handling setups. So when I do use ADM then just to make keyframe cuts using the older version 2.7.5 which is best version for that task. I was trying the latest version 2.8.2 but this is buggy unfortunately also with KF cutting and I get different & bad results out when using this latest version instead of the older version.
Problem 1: Wheel issue. Did anyone recognize that the wheel (keyframe jumping) dosen't get the focus on the first mouse click after you did click any button (play, frame forward / backward etc any button)? So you have to click twice on the weehl to set the focus and move it. So this is really bad if you edit a video. The old version does not have this problem and the wheel is working on first mouse-click.
Problem 2: Keyframe error message. Each time if I use the wheel or keyframe buttons back / for when the video is on start or end you get this message (can't change to next keyframe or pre keyframe). Just disable that error info message. So its clear that nothing is comming anymore before timecode 00:00:00.000. Just show nothing then. Also same with the end of the video. There is also a problem with the keyframe jump to the end of the video. Just load a video and press END key or the B button under the wheel to jump to the end of video. Now press one frame backward (left key) and then press one keyframe forward (up key) and now you get also that keyframe error message instead that the app jumps to the end of the video. Just remember, keyframe jumps should work for START (first frame) of video / keyframes in video itself & END of video (last frame). Not needed to show any error messages so this is just annoying & unnecessary.
Problem 3: Time-Stamps. Compared with bot ADM versions you will get different time stamps for same video. In the older version some videos do not start from 00:00:00.000 (target time display) and start with any higher time.
Example: Both versions compared. Below some images I made to show the differents when using old / new version / VirtualDub / FFprobe....
(https://i.postimg.cc/nVTt0Ltr/TT1-2023-03-01-214846.png)
...as you can see the times are all diffrent (messed) for same video. Correct times you can see in ffprobe & VD2 but not in ADM and thats also a problem. As video editor I want to get out correct results and not some round about stuff. Now lets try to select the entire video from start - end using A/B marker. In the newer version (first image) I get same selection length of 00:16:58.266 like in B field (entire video is shown with a length of 00:16:58.299). After saving the selection as new file just in copy-mode I get those video lenght results out: 30545 frames instead of 30549 = missing 4 frames. If you try the same with the older version which starts with "00:00:00.033" and I do select start - end A/B and save the selection in copy-mode then I get the right results out in the new saved video with 30549 frames = Original. This means that the older ADM version is still working better as the latest version (I have also test versions between but they also work not correct). All in all you should use better the older engine of version 2.7.5 which works much better as the newer ones. Otherwise check what the problem is and fix it. There are also problems when you append same video again and trying to make keyframe cuts which results into wrong error messages if you try to save it = not happen in older version. Sometime I also get "video to short" info if I try to save the video as it is without selection etc but in older version I don't get this error and saving works. Why?
(https://i.postimg.cc/rp1MCCJR/TT2-2023-03-01-214846.png)
So all in all there are still problems when using ADM you guys should check out again and fix them. One point I don't understand is why you devs not doing some tests to see whether everything is working before releasing a new version. Anyway, just my opinion. ADM is a nice tool on first view but no highlight after a deeper view & tests so there is still much air upwards to make it better. It just depends on you dev guys of ADM. Follow the ideas / bug reports of your users (like ME) and add & fix them or not. So for myself I can just say that I do prefer exact working tools (not "so lala" / round about / Hmmm, schau mer mal) with a logic and additional simple handling (no detours). Just can say it again, why the hell is there no close button / option. :) So thats one thing I can really not understand also tomorrow not. Sorry, but you as coder should know it better. The entire button toolbar is free except 4 buttons + zoom info and you don't use it for other function / buttons. But adding another 2 themes like dark-theme! This is so useless, the default theme is fine and I personal hate dark theme apps. You should better care about other important things as I told before and not don't put your attention on extra goodies cheese like that theme stuff. Anyway, just try to do something with my posts or not. Your choice.
Quote from: Silox on March 01, 2023, 10:11:36 PMNow lets try to select the entire video from start - end using A/B marker. In the newer version (first image) I get same selection length of 00:16:58.266 like in B field (entire video is shown with a length of 00:16:58.299).
The new version works correctly in this regard. The B marker is (and always was) an excluding marker, meaning the frame where the B marker is, is not part of the selection. Older versions had bugs in this regards. If you want to include the last frame, you shouldn't set the marker B.
Problem 1: it looks like a bug. You can use the mouse wheel on it though.
Problem 2: indeed very annoying. However the solution is not trivial, for various reasons.
Problem 3: other than the (probably) rounding error in the total length, the times are correct in the new version.
Quote from: Silox on March 01, 2023, 10:11:36 PMProblem 1: Wheel issue. Did anyone recognize that the wheel (keyframe jumping) dosen't get the focus on the first mouse click after you did click any button (play, frame forward / backward etc any button)?
Confirming the very minor but interesting issue, affects only navigation buttons in the navigation widget, not the marker buttons and the delete button between them, maybe related to activity / busy indicator, but not sure. The issue is very minor because there is no need to drag the thumb slider, just requires an extra click at the same mouse position.
At least on Linux, the mouse wheel can be used to move the thumb slider as far as the mouse pointer is placed within its boundaries, no matter where the focus is.
Quote from: Silox on March 01, 2023, 10:11:36 PMProblem 2: Keyframe error message. Each time if I use the wheel or keyframe buttons back / for when the video is on start or end you get this message (can't change to next keyframe or pre keyframe). Just disable that error info message. So its clear that nothing is comming anymore before timecode 00:00:00.000
ACK regarding silencing the error popup at zero linear time.
Quote from: Silox on March 01, 2023, 10:11:36 PMAlso same with the end of the video.
No, absolutely not. Depending on structure of the video stream, the first keyframe may be also the last keyframe (or all subsequent keyframes may have invalid timestamps). Additionally, the last frame has usually a non-zero duration (a large portion of your post arises from a misconception that the PTS of the last frame is or should be equal the duration of the video), nothing prevents this non-zero duration from being really long, even if such cases are uncommon. Therefore it is IMHO a valid goal to let the user know that attempts to advance using the "go to the next keyframe" button or the thumb slider are futile.
Quote from: Silox on March 01, 2023, 10:11:36 PMNow press one frame backward (left key) and then press one keyframe forward (up key) and now you get also that keyframe error message instead that the app jumps to the end of the video. Just remember, keyframe jumps should work for START (first frame) of video / keyframes in video itself & END of video (last frame).
This is plain wrong.
Quote from: Silox on March 01, 2023, 10:11:36 PMProblem 3: Time-Stamps. Compared with bot ADM versions you will get different time stamps for same video. In the older version some videos do not start from 00:00:00.000 (target time display) and start with any higher time.
Correct, since 2.8.0 (IIRC) Avidemux creates by default a segment layout with start time in reference video aligned at the first keyframe. This is the same as setting the B marker to the first keyframe in earlier versions and deleting the selection.
As video timestamps in Avidemux cannot be negative, it has to compensate for the frame reordering delay (i.e. in all video streams which make use of B-frames) by making the presentation timestamp of the first keyframe a positive non-zero value. This is different from many libraries and applications starting with FFmpeg which handle the frame reordering delay by making the decode timestamps of the first few frames negative.
Quote from: Silox on March 01, 2023, 10:11:36 PMAfter saving the selection as new file just in copy-mode I get those video lenght results out: 30545 frames instead of 30549 = missing 4 frames. If you try the same with the older version which starts with "00:00:00.033" and I do select start - end A/B and save the selection in copy-mode then I get the right results out in the new saved video with 30549 frames = Original. This means that the older ADM version is still working better as the latest version
I assume you try to edit an Open-GOP-style H.264 stream. The obsolete version you refer to didn't know how to tell droppable early B-frames from early B-frames used for reference and kept them all = more artifacts at the start of video depending on the behavior of the video player.
Quote from: Silox on March 01, 2023, 10:11:36 PMThere are also problems when you append same video again and trying to make keyframe cuts which results into wrong error messages if you try to save it = not happen in older version.
Please cite the error messages. The ability to check Open-GOP H.264 streams for possible problems at cut points like retrograde POC were not present in 2.7.5. Unjustified warnings due to bugs in POC calculation should be quite rare in 2.8.1 and subsequent nightly builds.
Quote from: Silox on March 01, 2023, 10:11:36 PMSometime I also get "video to short" info if I try to save the video as it is without selection etc but in older version I don't get this error and saving works. Why?
Please provide a sample video. If editing steps are necessary, please provide precise steps necessary to reproduce the error.
Quote from: eumagga0x2a on February 21, 2023, 11:42:50 PM1. Exactly, not a video player, therefore no need for fullscreen from my POV. However, an ability to inspect all areas of the picture even on small screens and at high zoom levels is sorely missed.
Well, you could implement some scrollbars... ADM definitely lacks them. More zoom options (such as in Virtualdub) could be useful too.
Quote from: szlldm on March 01, 2023, 11:47:40 PMThe new version works correctly in this regard. The B marker is (and always was) an excluding marker, meaning the frame where the B marker is, is not part of the selection. Older versions had bugs in this regards. If you want to include the last frame, you shouldn't set the marker B.
What are you talking about!=? The area from marker A - marker B are the frames which get saved. If you select just ONE frame only then you have to set marker A at start then you go forward one frame and set marker B and now you have selected one frame only = area between A & B. Now check this new result and you see the one frame in your video. When I do select entire video with A&B marker from start & end then I also do expect to get all frames saved specially in copy mode. Once again, when using the latest ADM version I get 2 different results out...
1.) Just load a video / choose copy mode V/A / save the video
2.) Just load a video / press marker A / press end key / save the video
------------------------------------------------------------------------
Outputvideo from task 1 = same video as oirignal = Correct!
Outputvideo from task 2 = NOT same / missing 4 frames at the end = Wrong!
------------------------------------------------------------------------You should get out the same results out if you do select the entire frame area. In case of latest version this does not happen (only showing it) what tells me that something is going wrong. In this case there are missing the last 4 frames in the video in case of task 2 but not in case of task 1. In my example video the frames have a length of 00.033 / 00.034 / 00.033 = 00.100 = 3 frames.
Now lets have again a look on the time stamps when using ADM old/latest/VD2/ffprobe.
(https://i.postimg.cc/nVTt0Ltr/TT1-2023-03-01-214846.png)
Here you can see already the differents in ADM old/latest and correct times in VD2 & ffprobe. The video length is "16:58.300".
ADM old: Starts after first frame 00.033 but showing right duration of 16:58.300
ADM new: Starts at 00 but showing wrong duration of 16:58.299 - why? Where is the time of 00.001?As I said, the original video has a video duration of 16:58.300 & 30549 frames!
ADM old does show the entire correct duration but ADM new not.
ADM old I can select a total duration of 16:58.299
ADM new I can select a total duration of 16:58.266
ADM old with total selection does output a video with a duration of 16:58.300 & 30549 frames = Correct!
ADM new with total selection does output a video with a duration of 16:58.167 & 30545 frames = Wrong!Have a look on ADM new image above I did post. The B button what is showing the total duration (you can click on it) of 16:58.299 does also NOT jump to this position and only jumps to 16:58.266. In old ADM it does jump to 16:58.299. Even when old ADM is not showing the time correctly for 100 % its working nevertheless more correct as the lastest ADM version. The only thing you have to do it TESTING.
Quote from: eumagga0x2a on March 02, 2023, 12:03:45 AMThe issue is very minor because there is no need to drag the thumb slider, just requires an extra click at the same mouse position.
So thats your excuse? Just needs a extra click! Great answer! I have an answer for you too. Its a bug you don't have in version 2.7.5 so just fix it. What the heck is wrong with you guys? Always having excuses for anything or what? (Bin ich hier im falschen Film oder was?) :)
Quote from: eumagga0x2a on March 02, 2023, 12:03:45 AMNo, absolutely not.
Just test it! Its also happens randomly sometimes. Just check the start / end to trigger the error messages.
Quote from: eumagga0x2a on March 02, 2023, 12:03:45 AMThis is plain wrong.
Test it! I would just recommend to wake up and stop dreaming eumagga0x2a. Test the things by yourself I was talking about all the time and then you will recognize them too.
There is also a problem when using copy-mode setup and trying to cut NOT on keyframes. Normally you should get a info message of the endpoint of keyframe of selection "Continue or not?". But this info message does not popup always when I have set marker on NOT keyframe positions and then the selection gets just deleted without any info. Why does it just show the info box when having not set the B marker on keyframe? In case of A marker it does not show the info box = wrong. Pos start / end of selection must treat same.
All in all, just check again the time stamps show and handle them correctly (entire duration) as I said already. All you can also reroduce by yourself so you just need to test a little more intense. Lets make ADM better (again or for the first time). :) Your app is not the first one I'am trying to help to improve with bug reports and new ideas. You just have to listen to me, Burli! I like ADM but I know you get improve it much more and I just don't check why you don't want you know.
PS / Off-Topic: Also eumagga0x2a, jetzt sieh mal zu das du die Probleme gebacken bekommst sonst quarken wir nächstes Jahr noch hier rum. Komm in die Puschen und mach mal voran und komm mir net wieder mit so komischen Ausreden um die Ecke! Also weißt bescheid was zu tun ist ne. Hopp!
Quote from: Silox on March 02, 2023, 11:53:50 PMWhat are you talking about!=? The area from marker A - marker B are the frames which get saved. If you select just ONE frame only then you have to set marker A at start then you go forward one frame and set marker B and now you have selected one frame only = area between A & B. Now check this new result and you see the one frame in your video. When I do select entire video with A&B marker from start & end then I also do expect to get all frames saved specially in copy mode.
The first half is true, meanwhile you conradicts yourself int the last sentence.
If you set marker B on the last frame as on your screenshots (which is not equivalent to marker B at the end!), the last frame is not included into the selection.
Quote from: szlldm on March 03, 2023, 01:52:11 AMQuote from: Silox on March 02, 2023, 11:53:50 PMWhat are you talking about!=? The area from marker A - marker B are the frames which get saved. If you select just ONE frame only then you have to set marker A at start then you go forward one frame and set marker B and now you have selected one frame only = area between A & B. Now check this new result and you see the one frame in your video. When I do select entire video with A&B marker from start & end then I also do expect to get all frames saved specially in copy mode.
The first half is true, meanwhile you conradicts yourself int the last sentence.
If you set marker B on the last frame as on your screenshots (which is not equivalent to marker B at the end!), the last frame is not included into the selection.
My guess is he is under the misconception that A and B markers fall "between" frames, not "on" frames.
It's simple. If A is on frame 1, and B on frame 10, frames 1 to 9 are saved. The A frame (1) is included, the B frame (10) excluded.
Sark
The attached image explains how markers work. If marker B is at :05, the frame starting at :05 will not be included into the selection. (If you set B marker on the last frame, the last frame will be excluded)
Quote from: szlldm on March 03, 2023, 01:52:11 AMThe first half is true, meanwhile you conradicts yourself int the last sentence.
If you set marker B on the last frame as on your screenshots (
Quote from: szlldm on March 03, 2023, 01:53:34 PMThe attached image explains how markers work. If marker B is at :05, the frame starting at :05 will not be included into the selection. (If you set B marker on the last frame, the last frame will be excluded)
to marker B at the end!), the last frame is not included into the selection.
I understand how the marker works guys, I just don't understand why you said that the LAST frame gets excluded. This makes also no sense. The older version 2.7.5 even does not exclude the last frame and even other video editors don't do that. You should get what you select. Instead of NOT exluding the last frame I can not select you should add a last pseudo frame like VD does.
Example: You have a video with 5 frame like on the image you did post @szlldm. If you want to keep all 5 frames original then you have NOT to use markers in latest ADM because it does not save the last frame as you said. What if I want to have the last frame included and want to use markers as selection part? Not working then. What if I want to cut away the last frame or a area from last frame to pre frames? Also not working when I can not select it in latest version of ADM. All in all it should be always possible to select all frames in a video editor without any strange selfmade custom rules what makes no sense. Also you would get some video edit problems if you cut a loaded video and you then append another video/s etc you know. Otherwise you as user must always keep in mind that ADM works differently and keep attention if you want to cut anything from last area of the video = keeps last frame into = unclean cut because last frame is still there. My opinion.
Quote from: Silox on March 03, 2023, 08:25:55 PMWhat if I want to have the last frame included and want to use markers as selection part? Not working then. What if I want to cut away the last frame or a area from last frame to pre frames? Also not working when I can not select it in latest version of ADM.
You just have to reset marker B (Ctrl+Shift+PageDown). Also it is enough to set only marker A if there is no selection yet.
Then the last frame is included.
Quote from: Silox on March 03, 2023, 08:25:55 PMAll in all it should be always possible to select all frames in a video editor without any strange selfmade custom rules what makes no sense.
If you do not make any selection at all, then all frames (entire video) are selected.
The selection tool is for cases where you don't want all the frames. Pretty straightforward.
Quote from: szlldm on March 03, 2023, 01:53:34 PMThe attached image explains how markers work.
The image explains it perfectly. Whilst the markers are at frames 1 & 5, they are at the start of the frames, only 1 to 4 are included within the range.
Quote from: Silox on March 03, 2023, 08:25:55 PMI understand how the marker works guys, I just don't understand why you said that LAST frame gets excluded
You previously stated that selecting the first frame (A) and the next frame (B) would save ONE frame (correct). However, this would be incorrect if ALL selected frames (TWO) were saved, as you are requesting.
This begs the question, if ALL selected frames were included when saving, how would you save ONE frame. Markers A and B would both need to be on the same frame!!!!
Sark
Quote from: szlldm on March 03, 2023, 11:11:17 PMYou just have to reset marker B (Ctrl+Shift+PageDown). Also it is enough to set only marker A if there is no selection yet.
Then the last frame is included.
When I just set marker A from anywhere then it does set marker B by itself and does select all the rest and does not include the last frame. Only NO selection does it.
Quote from: szlldm on March 03, 2023, 11:11:17 PMIf you do not make any selection at all, then all frames (entire video) are selected.
The selection tool is for cases where you don't want all the frames. Pretty straightforward.
Also in this case the user has NO CHANCE to cut out the LAST FRAME or last keyframe till last frame area (LastKeyframe / frames till last frame *)! Don't you see this guys? Just create any small video with few diffrent frames for each frame and then try it by yourself. The question in this case is how to cut away the last frame? Not doable because there is missing a forward going pseudo frame at the end. If it would be there then you could also select the last frame and cut it out. In this case I also can not do any keyframe cut at the end because I can not select it = info message about keyframe enpoint not in selection etc. If you would add a pseudo frame at the end then you could also select the last frame = correct position of video end and you could cut it via keyframe.
Example: I made short video with 10 diffrent frame images. It only has one start keyframe (I-Frame)(first frame) and the last frame what you can count as keyframe too. As I said before, in case of keyframe cutting you can see the last frame as KF too (I know its not really). In ADM you can not select last frame = you can't do correct keyframe cut from the end or till end and you miss the last keyframe area.
When you load the video in ADM then you can see all frames one by one but as I said before you can not select the last frame because of missing pseudo placeholder frame what you have in VirtualDub (grayed-frame for editing). That means if I want to edit the last visible frame in ADM then it will not work because I can not select it. Just can do it without selection. The only chance to edit the last frame is when just adding another frames to video and then you can also select the first video completely or just from last frame - pre frames. So in my eyes its a bad detour and somehow confusing or the most people. Just look at this new image I made...
(https://i.postimg.cc/y8HL6GmS/O1-2023-03-04-224121.png)
...do you see? Just think again about it. Maybe people did think in case of using VirtualDub why its showing always a gray frame at the end but it makes sense of course because of the reason I did told you already. In case of ADM its not showing any pseudo frame = limited in editing with last frame / keyframe area. Anyway, just wonder why I'am the only one again who is seeing that as problem in ADM.
PS: Pseudo frame at the end is just needed to get also the last frame selected (see VD). This get not saved in the video of course because its just a placeholder / marker / pointer whatever you want to call it. But with such a feature you can also select every frame in a video without to exclude anything. Just don't get why you don't check that. Don't get me wrong guys, its not my intention to attack anyone here and just trying to explain my point of view about ADM.
Normally I do use VirtualDub2 to edit videos I do encode at the end but since VD2 its no more possible to do keyframe cuttings (total worse in VD2 / dev Anton don't wanna fix this) what was working in VD1 (just to save in avi container only). Later I was using ADM for keyframe cuttings (2.7.5) which is good for that (except from few problems I told before already etc) and I'am still using it for this task but ADM could be changed to a much better editing tool but unfortunately the will does not seem to be present you know. :(
Quote from: Silox on March 04, 2023, 10:38:13 PMAlso in this case the user has NO CHANCE to cut out the LAST FRAME or last keyframe till last frame area (LastKeyframe / frames till last frame *)! Don't you see this guys? Just create any small video with few diffrent frames for each frame and then try it by yourself. The question in this case is how to cut away the last frame? Not doable because there is missing a forward going pseudo frame at the end.
It is simple. Set marker A at the last frame. That's it.
lastfrm.png
Quote from: szlldm on March 05, 2023, 12:36:28 AMIt is simple. Set marker A at the last frame. That's it.
Uhhmm! ;D Ok wait, so now I see I can select that last frame and cut it away just using marker A!? That makes me wonder now. Never have seen that before. Strange, but seems to work now. :) So that means at the end there must be always one frame left what I can not delete. Just see when I load a video and press just marker A from start position then nothing gets seleted but if I move one frame forward and press marker A then all the rest gets selected. Ok, now I got it. Thank you for that info. ;) This problem seems to be fixed now. Just need to keep this in my mind when I edit with ADM. Sorry, my fault (hope you don't mind to much).
Another question about wrong / invalid timestamps in videos. Sometimes I get that message if I wanna save the video (when editing is finished / ready to save) and then the video is not saved correctly. Why don't you check this problem about wrong time-stamps when loading the video and print then a info message about possible wrong timestamps etc? Its of course bad to get that info just when I wanna save the video you know, in this case the entire video edit process was for free. Otherwise is there no option in ADM to fix those timestamps on loading? Normally I just need to use ffmpeg in copy mode to fix those problems and then I can also edit this new fixed file in ADM correctly. Would be nice if ADM could do this too on loading etc if possible. Bellow the error message in case of wrong ts's files...
---------------------------
Hinweis
---------------------------
Video zu kurz
Das gespeicherte Video ist unvollständig.
Der Fehler ereignete sich bei 00:00:05,654 (10). Dies kann eine Folge ungültiger Zeitstempel im Video sein.
Error -22 ("Invalid argument")
---------------------------
OK
---------------------------Is there also any method to prevent creating the idx2 files on disk or at all? A option to turn this on/off would be nice. Most videos I just edit once and then I need to delete all those idx2 files manually.
Quote from: Silox on March 05, 2023, 08:46:52 PMBellow the error message in case of wrong ts's files...
Providing a sample source video with exact steps to reproduce the dts collision might be of some use. Citing the standard error message is useless.
Quote from: Silox on March 05, 2023, 08:46:52 PMIs there also any method to prevent creating the idx2 files on disk or at all?
Making MPEG-TS and MPEG-PS demuxers capable of handling videos stored on read-only media by keeping the index in memory instead of dumping it to an .idx2 text file is on my todo list. MPEG streams are slow to index as there is no central structure to hold the location of data, therefore writing the index to mass storage when this is doable makes a lot of sense for the majority of use cases.