Author Topic: 2.6 r7732 - patch fixes incorrect pluginSettings path on OSX  (Read 3787 times)

nibbles

  • Sr. Member
  • ****
  • Posts: 292
2.6 r7732 - patch fixes incorrect pluginSettings path on OSX
« on: February 04, 2012, 10:16:44 PM »
Using 2.6 r7732 on Apple OSX, I think ADM_fileio.cpp may need adjusting so Avidemux can find pluginSettings.
I've seen main.cpp do this:

Code: [Select]
//***************Plugins *********************
// Load system wide audio decoder plugin
#ifdef __APPLE__
    const char *startDir="../lib";
#else
    const char *startDir=ADM_RELATIVE_LIB_DIR;
#endif
    char *adPlugins = ADM_getInstallRelativePath(startDir, ADM_PLUGIN_DIR, "audioDecoder");
    char *avPlugins = ADM_getInstallRelativePath(startDir, ADM_PLUGIN_DIR, "audioDevices");   
    char *aePlugins = ADM_getInstallRelativePath(startDir, ADM_PLUGIN_DIR, "audioEncoders");   

but ADM_fileio.cpp uses only the ADM_RELATIVE_LIB_DIR, which doesn't quite work:

Code: [Select]
const char *ADM_getSystemPluginSettingsDir(void)
{
    if(ADM_systemPluginSettings) return ADM_systemPluginSettings;
    ADM_systemPluginSettings=ADM_getInstallRelativePath(ADM_RELATIVE_LIB_DIR, ADM_PLUGIN_DIR, "pluginSettings");
    return ADM_systemPluginSettings;
}

yielding the path:

Code: [Select]
  [paintGL]  Painting dummy openGl widget
  [HandleAction]  ************ VIDEO_CODEC_CONFIGURE **************
  [ADM_pluginSystemPath]  System Plugin preset path : /usr/local/bin/lib/ADM_plugins6/pluginSettings//x264/1
  [ADM_pluginInstallSystem]  Looking for file .json in folder /usr/local/bin/lib/ADM_plugins6/pluginSettings//x264/1


So the patch would look something like this.
Ok thanks.

Agent_007

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3163
Re: 2.6 r7732 - patch fixes incorrect pluginSettings path on OSX
« Reply #1 on: February 05, 2012, 11:11:23 AM »
Bump this thread if Mean doesn't comment this during next week, so I remember to ticket this.
I am away between 15th of May - 15th of June. (yes, I am playing D3)

nibbles

  • Sr. Member
  • ****
  • Posts: 292
Re: 2.6 r7732 - patch fixes incorrect pluginSettings path on OSX
« Reply #2 on: February 28, 2012, 03:38:03 AM »
bump.  thanks LM 

mean

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 10974
Re: 2.6 r7732 - patch fixes incorrect pluginSettings path on OSX
« Reply #3 on: February 28, 2012, 06:43:13 AM »
Now would be a good time to give me your berlios ID so that i can grant you svn commit access.
(you must promise to be good though)