[cosmetic] "extractSPSInfo_lavcodec" log has misplaced line endings

Started by mm0359, August 26, 2016, 03:08:59 AM

Previous topic - Next topic

mm0359

admlog.txt:

  Avidemux v2.6.13 (160825_dbff7c1aee7) .

...
[extractSPSInfo_lavcodec] Incoming SPS info

0000 : M@.Ã...¡bÃ,hHÃ,°D   Ã,¨..  4d 40 1e 9a 62 81 68 48 b0 44 20 a0 a0 a8 00 00
0010 : .......ââ,¬Â   03 00 08 00 00 03 01 94 a0[extractSPSInfo_lavcodec]
converted SPS info

0000 : .M@.ÿá."gM@.Ã...¡bÃ,h  01 4d 40 1f ff e1 00 22 67 4d 40 1e 9a 62 81 68
0010 : HÃ,°D   Ã,¨.........  48 b0 44 20 a0 a0 a8 00 00 03 00 08 00 00 03 01
0020 : ââ,¬Â ..$€....!  94 a0 01 01 24 80 00 00 00 01 21[extractSPSInfo_lavcodec]
...


Source is:

avidemux_core/ADM_coreUtils/src/ADM_infoExtractorH264.cpp#L775

uint8_t extractSPSInfo_lavcodec (uint8_t * data, uint32_t len, ADM_SPSInfo *spsinfo)

...
    ADM_info("Incoming SPS info\n");
    mixDump(data,len);
   
    ADM_info("\nconverted SPS info\n");
...
    mixDump(buffer,converted);
    ADM_info("\n");
...


Possible solutions:
1- Add a "\n" at end of "mixDump()".
2- Create and use (something like) an "ADM_newline() { printf("\n"); }".

mm0359

See Pull Request #21

Based on mixDump() calls diversity.