Crash navigating after delete

[eumagga0x2a]

Testcase: YouTube video ID QbUQUaB24 ("Bulldog and a parrot-2"), format 18 (or 43).

STR:

• Open the testcase in Avidemux, press END to go to the end of the video, then Ctrl+DOWN to set the Marker B.
• Press UP to go to the previous keyframe and Ctrl+PgUp to set the Marker A.
• Press DEL, then UP and DOWN.

Actual Results:

Avidemux reproducibly crashes with

Code Select Expand


Assert failed :twoFlags&AVI_KEY_FRAME
at line 415, file /home/eumagga/avidemux/git/avidemux2/avidemux/qt4/common/ADM_editor/src/ADM_edRenderInternal.cppADM_backTrack
ADM_Composer::DecodePictureUpToIntra(unsigned int, unsigned int)
ADM_Composer::goToIntraTimeVideo(unsigned long)
admPreview::seekToIntraPts(unsigned long)
admPreview::nextKeyFrame()
GUI_NextKeyFrame()
HandleAction_Navigate(Action)
HandleAction(Action)
/usr/local/bin/avidemux3_qt5() [0x4a1583]
QMetaObject::activate(QObject*, int, int, void**)
MainWindow::actionSignal(Action)
MainWindow::searchMenu(QAction*, MenuEntry*, int)
/usr/local/bin/avidemux3_qt5() [0x4a141c]
QMetaObject::activate(QObject*, int, int, void**)
QMenu::triggered(QAction*)


QMetaObject::activate(QObject*, int, int, void**)
QAction::triggered(bool)
QAction::activate(QAction::ActionEvent)
QAction::event(QEvent*)
QApplicationPrivate::notify_helper(QObject*, QEvent*)
QApplication::notify(QObject*, QEvent*)
QCoreApplication::notifyInternal2(QObject*, QEvent*)
QShortcutMap::dispatchEvent(QKeyEvent*)
QShortcutMap::tryShortcut(QKeyEvent*)
QWindowSystemInterface::handleShortcutEvent(QWindow*, unsigned long, int, QFlags<Qt::KeyboardModifier>, unsigned int, unsigned int, unsigned int, QString const&, bool, unsigned short)
QGuiApplicationPrivate::processKeyEvent(QWindowSystemInterfacePrivate::KeyEvent*)
QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*)
QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>)

as backtrace.

Please note that this happens with pretty all videos and is not restricted to h264.

[ajschult]

Yes, see http://avidemux.org/smif/index.php/topic,11557.msg60516.html#msg60516

The patch suggested in the next comment fixes your crash.  I've submitted a pull request

https://github.com/mean00/avidemux2/pull/18

[eumagga0x2a]

Thank you very much and apologies for the dupe. It is a bit unsettling that a crash bug with a known solution can remain unfixed for almost four years.