v2.6.14_ffmpeg31 (to v2.6.18_ffmpeg31) crashes when trying to index .ts files

[mm0359]

Windows: XP and Vista. (win32)

On WinXP,

"avidemux.exe",

  Avidemux v2.6.14 (160927_ef745605b41) .
(FFmpeg v3.0.3) still works fine.

Code Select Expand


...
[extractSPSInfo_mp4Header] Context created
Used bytes 0/43 (+5)
[extractSPSInfo_mp4Header] Failed to extract SPS info
[extractSPSInfo_mp4Header] Width  : 0
[extractSPSInfo_mp4Header] Height : 0
Scale : 50, tick=1, fps=50000
Crop L: 0
Crop R: 0
Crop T: 0
Crop B: 0
[extractSPSInfo_mp4Header] Width2 : 720
[extractSPSInfo_mp4Header] Height2: 576
[extractSPSInfo] width:720
...


  Avidemux v2.6.14 (161002_bd8821bc6a1) .
(FFmpeg v3.1.4) crashes (before indexing first frame).

Code Select Expand


...
[extractSPSInfo_mp4Header] Context created
[adm_lavLogCallback] [lavc] AVC-parser: nal length size invalid
Used bytes 0/43 (+5)
[extractSPSInfo_mp4Header] Failed to extract SPS info
[extractSPSInfo_mp4Header] Width  : 0
[extractSPSInfo_mp4Header] Height : 0
Saving crash file to ...\avidemux\crash.py
EXCEPTION_ACCESS_VIOLATION
ff_h264_info  [avcodec-57.dll]
Crash Dump for ExceptionFilter
EXCEPTION_ACCESS_VIOLATION
ff_h264_info  [avcodec-57.dll]
ADM_setCrashHook  [libADM_core6.dll]
ADM_setCrashHook  [libADM_core6.dll]
FindAtomW  [kernel32.dll]
...


Issue 1: Do not crash.
Issue 2: Index file.

NB:
If the .ts.idx2 file already exists (created with a previous version), then it loads fine.
(I didn't try other file types.)



On WinVista,
same exception, with a different stack:

Code Select Expand


EXCEPTION_ACCESS_VIOLATION
ff_h264_info  [avcodec-57.dll]
Crash Dump for ExceptionFilter
EXCEPTION_ACCESS_VIOLATION
ff_h264_info  [avcodec-57.dll]
ADM_setCrashHook  [libADM_core6.dll]
ADM_setCrashHook  [libADM_core6.dll]
EtwSendNotification  [ntdll.dll]
RtlInitializeExceptionChain  [ntdll.dll]


[mm0359]

Ftr, ff_h264_info is a (Avidemux) patch added function.

(Debugging needed...)

[mean]

Thanks, but dont spend too much time playing with the ffmpeg31, it's just a toy at the moment

[mm0359]

[...] the ffmpeg31, it's just a toy at the moment

Thanks. Noted.
It's good to have early feedback, both ways.

Given this indexing crash, I won't use this branch, unless I/you want to check something specific.

[mm0359]

Ftr, after upgrading Windows XP to SP3 (from "SP2").

Installed Debug Diagnostic Tool 1.2:

Code Select Expand


  Avidemux v2.6.14 (161024_8b5bfb9baa1) .


Type of Analysis Performed   Crash Analysis

Thread 0 - System ID 5892
Entry point   avidemux+14c0

Full Call Stack

Function     Arg 1     Arg 2     Arg 3     Arg 4   Source
avcodec_57!ff_h264_info+4b     657441da     65752694     6bf2a2cd     65755980   
msvcrt!printf+55     031eb020     0022c924     00000000     0022c924   
libADM_coreUtils6!Z24extractSPSInfo_mp4HeaderPhjP11ADM_SPSInfo+1cd     0022c970     0000002b     031b8f38     000000b8   
libADM_coreUtils6!Z24extractSPSInfo_mp4HeaderPhjP11ADM_SPSInfo+3f5     030f8928     02ff807c     0022ccb8     7c910098   
libADM_dm_ts!Z9tsIndexerPKc+6f5     030f8928     67c61636     030f8928     000002f8   
libADM_dm_ts!probe+c0     1cda0747     030f8928     77c5fd00     77c40ad6   
libADM_coreDemuxer6!Z16ADM_demuxerSpawnjPKc+36     00000000     00000000     00000000     00000000   

Exception Information
...
the assembly instruction at avcodec_57!ff_h264_info+4b in ...\avcodec-57.dll has caused an access violation exception (0xC0000005) when trying to read from memory location 0x00000000 on thread 0

Symbol File Name:  avcodec-57.dll


NB: This example is with my LoadTst.ts file.

[mm0359]

Ftr, "same" crash with win32_ffmpeg31/avidemux_2.6.18_r170304_win32.exe

[mm0359]

win32_ffmpeg31/avidemux_2.6.18_r170311_win32.exe
can index (and at least play) .ts.

Fixed...