Author Topic: Black filter bug?  (Read 670 times)

flumuxxed

  • Newbie
  • *
  • Posts: 1
Black filter bug?
« on: January 11, 2018, 11:45:27 AM »
What I am doing (exporting clip)

 1) Fade to black about 1 second before end of clip
 2) Replace the remaining frames in clip with black while 1 second of audio runs underneath

It works correctly in Video Filter Manager preview
It works correctly in main editor window with "play filtered"

But the wrong times are displayed in Black filter, and when I export the clip, the frames at end are not blacked out.  (Using HEVC with MP4 muxer)

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 6052
Re: Black filter bug?
« Reply #1 on: January 11, 2018, 01:21:47 PM »
Update:

Black filter does indeed give wrong times in: Active Filters :Black: Start time and End time (not matching the entries made)
I'm still testing if the filter is wrongly applied whilst re-encoding, takes hour(s) saving video.

-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_

Most likely the order of applied filters is incorrect

This works:
Video Output: HEVC (x265)
Output Format: MP4 muxer

duration clip: 00:00:37.940

Active Filters:
Fade to black:
 start: 00:00:32.900
 end  : 00:00:34.300

Black:
 start: 00:00:34.300
 end : 00:00:37.940

end result:

YouTube Combined filters: Fade to black + black
« Last Edit: January 11, 2018, 04:56:32 PM by Jan Gruuthuse »

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 6052
Re: Black filter bug?
« Reply #2 on: January 11, 2018, 04:46:37 PM »
I have to redo test tomorrow.
Was inconclusive. Probably need testing with over 10 second black to find if black was encoded somewhere else in video.

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 6052
Re: Black filter bug?
« Reply #3 on: January 11, 2018, 05:13:24 PM »
It seems the end of the movie is cut, tested with VideoOutput: Nvidia H264
- 1.24.59.900 duration original clip
- 1.24.40.000 duration saved clip

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 2296
Re: Black filter bug?
« Reply #4 on: January 12, 2018, 12:57:54 AM »
Works for me with the current git master so far, no wrong parameters shown for "black", no anomalies saving the result in the combination of "fade to black" + "black" as well as with "crop" and "eq2" in between. Please retest with the latest nightly.

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 6052
Re: Black filter bug?
« Reply #5 on: January 12, 2018, 07:15:47 AM »
Did a test rerun with commit 60dda2a
and confirm a conclusive test: saved re encoded video has the same length as original: 1.24.59.900 duration.

Then there is only the small issue left on Black filter not showing the correct timings in active filters.

Start time (ms): 01h:24m:39s,900 -> Black: Start 00:13:04,923
End   time (ms): 01h:24m:59s,900 -> Black: End   00:13:24,923



eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 2296
Re: Black filter bug?
« Reply #6 on: January 13, 2018, 11:40:04 AM »
Should be fixed now, we were using integer type with size too small to store high start/end time values, causing the displayed time to wrap around.

Jan Gruuthuse

  • Hero Member
  • *****
  • Posts: 6052
Re: Black filter bug?
« Reply #7 on: January 13, 2018, 01:48:28 PM »
Confirmed, black displays values now correctly in active filters.
« Last Edit: January 13, 2018, 01:50:37 PM by Jan Gruuthuse »