[ SOLVED ] No subtitle filters with Avidemux 2.7.4 (Linux).

Started by Gandalf, January 06, 2021, 07:04:12 AM

Previous topic - Next topic

eumagga0x2a

(Obviously, only the last command in the one-liner above builds Avidemux, all other chained commands prepare the source)

Gandalf

January 28, 2021, 05:57:27 PM #16 Last Edit: January 28, 2021, 08:17:24 PM by Gandalf Reason: corrected a typing error.
I finally got the subtitle filters to function correctly using the following solution provided by a Slackware support forum that I am a member of:
QuoteThe answer is simple, but not easy to find when you create posts thinking you need to modify system libraries.

Simply comment out or remove line 78 in the avidemux.SlackBuild. It seems that sed command prevents the subtitle filter to be created.

This is the command that needs to be removed/commented out:

Code:

sed -i 's|0.19|1.0|' avidemux_plugins/ADM_videoFilters6/ass/CMakeLists.txt || exit 1

it's intended for those of you who use Slackware 14.2 as your operating system.

Gandalf

Quote from: eumagga0x2a on January 17, 2021, 01:05:49 AM
Quote from: Gandalf on January 17, 2021, 12:31:04 AMI always build Slackware packages as "root"

This is a terrible, very dangerous practice. You really shouldn't.

Quote from: Gandalf on January 17, 2021, 12:31:04 AMAnd since you don't recommend building 2.7.6, what DO you recommend?

As mentioned already on three occasions in this topic, I recommend building Avidemux from the git master:

git clone https://github.com/mean00/avidemux2.git && cd avidemux2 && git submodule update --init --recursive && bash bootStrap.bash --with-system-libass > ~/admCmakeLog.txt 2>&1
For your information (for what it's worth) Slackware won't let you build packages unless you're logged on as 'root'.

eumagga0x2a

Quote from: Gandalf on January 28, 2021, 05:57:27 PMSimply comment out or remove line 78 in the avidemux.SlackBuild. It seems that sed command prevents the subtitle filter to be created.

This is the command that needs to be removed/commented out:
sed -i 's|0.19|1.0|' avidemux_plugins/ADM_videoFilters6/ass/CMakeLists.txt || exit 1

Which version of fribidi does your Slackware installation have? Avidemux requires at least 0.19. Slackware package maintainer seems to have chosen to patch the test in Avidemux to require version 1.0 as minimum.

Quote from: Gandalf on January 29, 2021, 04:23:57 AMFor your information (for what it's worth) Slackware won't let you build packages unless you're logged on as 'root'.

I am not familiar with Slackware build infrastructure, it may require root permissions to initiate the package creation and drop them for the build step. It is also possible that some tools are "hidden" from ordinary users like on SuSE by not including some directories (especially everything with sbin) into $PATH.

If you compile an application or library yourself, please never ever invoke build scripts (configure, make) as root. The only exception is the final "make install" call, which will inevitably require root permissions if you install something to the default prefix.

Gandalf

QuoteWhich version of fribidi does your Slackware installation have? Avidemux requires at least 0.19. Slackware package maintainer seems to have chosen to patch the test in Avidemux to require version 1.0 as minimum.
0.19.7

eumagga0x2a

Quote from: Gandalf on January 29, 2021, 06:24:08 PM0.19.7

Indeed, this is the official version in 14.2, the version 1.0.10 is in master. Therefore, SlackBuild for avidemux patching Avidemux cmake script to require 1.0 on the branch for 14.2 (https://git.slackbuilds.org/slackbuilds/tree/multimedia/avidemux/avidemux.SlackBuild?h=14.2) is a bug, you should probably report it to Matteo Bernardini.

And yes, Slackware builds as root, albeit in a temporary directory. Please don't do it when you realize that 2.7.6 is very old and buggy and evaluate trying the git master. Building as root is really a very dangerous practice, unsupported and discouraged for Avidemux.