Garbled sound with some webm videos

[eumagga0x2a]

Maybe as fallout from recent vorbis-related commits, the sound in the webm video https://www.youtube.com/watch?v=2-QbUQUaB24 with format code 43 has become garbled on playback. ffprobe reports for the file:

Code Select Expand

Input #0, matroska,webm, from 'a_dog_and_a_parrot.webm':
  Metadata:
    encoder         : google
  Duration: 00:00:24.50, start: 0.000000, bitrate: 900 kb/s
    Stream #0:0: Video: vp8, yuv420p, 480x360, SAR 1:1 DAR 4:3, 30 fps, 30 tbr, 1k tbn, 1k tbc (default)
    Stream #0:1: Audio: vorbis, 44100 Hz, mono, fltp (default)


[mean]

Works ok here, but i have a stereo sound track
?

[eumagga0x2a]

Yeah, Google has ruined the testcase... I used this video retrieved four years ago with mono. Trying to identify the first bad commit now.

[eumagga0x2a]

The first bad commit is [lavcodec/audio] Enable vorbis decoder.

I attach the first 100K of the audio track demonstrating the issue.

[eumagga0x2a]

Here comes the second chunk...

[eumagga0x2a]

...and the last one.

[eumagga0x2a]

A better, minimal test case. The sound should be silent, but is garbled noise in Avidemux. ffprobe reports:

Code Select Expand

Input #0, matroska,webm, from 'frame800x640-with-mono-sound.mkv':
  Metadata:
    ENCODER         : Lavf57.25.100
  Duration: 00:00:05.16, start: 0.000000, bitrate: 62 kb/s
    Stream #0:0: Video: h264 (High), yuv420p, 800x640, SAR 1:1 DAR 5:4, 25 fps, 25 tbr, 1k tbn, 50 tbc (default)
    Metadata:
      ENCODER         : Lavc57.24.102 libx264
      DURATION        : 00:00:05.163000000
    Stream #0:1: Audio: vorbis, 48000 Hz, mono, fltp (default)
    Metadata:
      ENCODER         : Lavc57.24.102 libvorbis
      DURATION        : 00:00:05.007000000

[mean]

If you delete the ad_lav_xxx.so, it will pick up the libvorbis one
Is the sound ok with the libvorbis one ?

[mean]

ok, can reproduce i think
thanks

[eumagga0x2a]

If you delete the ad_lav_xxx.so, it will pick up the libvorbis one
Is the sound ok with the libvorbis one ?

Yes, it works fine with libADM_ad_lav.so moved.

[mean]

Should work now

[eumagga0x2a]

Confirming fixed by [AudioDecoder/ff] Fix decoding to float (obvious for mono streams), thanks! Do we have everything for a release then, a couple of editor bits and regeneration of .ts files + a couple of translations outstanding?

[mean]

Some sierra + win32 stuff

[eumagga0x2a]

Thanks, I just mind the looming release of Fedora 25 in 2 or 3 weeks (if they delay), it would be nice to bring the rpmfusion.org Avidemux package maintainers off the old 2.6.12 release with Qt4 in time for Fedora 25 release.