Fixed ** Failed at make, result in /tmp/logbuildPluginsCommon**

[Jan Gruuthuse]

Fixed: ae36e2b            [core] Fix compilation breakage

commit 5f2d129 on ubuntu 16.04.04 LTS 64-bit,
PythonScriptWriter.cpp.o' failed ?

Code Select Expand

ADM_scriptEngines/tinyPy/src/CMakeFiles/ADM_script_tinyPy.dir/build.make:161: recipe for target 'ADM_scriptEngines/tinyPy/src/CMakeFiles/ADM_script_tinyPy.dir/PythonScriptWriter.cpp.o' failed
make[2]: *** [ADM_scriptEngines/tinyPy/src/CMakeFiles/ADM_script_tinyPy.dir/PythonScriptWriter.cpp.o] Error 1
make[2]: Leaving directory '/home/jan/avidemux2/buildPluginsCommon'
CMakeFiles/Makefile2:3230: recipe for target 'ADM_scriptEngines/tinyPy/src/CMakeFiles/ADM_script_tinyPy.dir/all' failed
make[1]: *** [ADM_scriptEngines/tinyPy/src/CMakeFiles/ADM_script_tinyPy.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Code Select Expand

Makefile:152: recipe for target 'all' failed
make: *** [all] Error 2

[eumagga0x2a]

The error is

Code Select Expand

/home/jan/avidemux2/install/usr/include/avidemux/2.7/ADM_coreVideoEncoder/ADM_coreVideoEncoder.h: In member function 'virtual bool ADM_coreVideoEncoder::setup()':
/home/jan/avidemux2/install/usr/include/avidemux/2.7/ADM_coreVideoEncoder/ADM_coreVideoEncoder.h:62:106: error: 'ADM_info' was not declared in this scope


[Jan Gruuthuse]

thnx for digging this out.

[eumagga0x2a]

You can use either

Code Select Expand

diff --git a/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoder.h b/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoder.h
index 5f39efe4..cb7381c6 100644
--- a/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoder.h
+++ b/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoder.h
@@ -18,6 +18,7 @@
#ifndef ADM_CORE_VIDEO_ENCODER_H
#define ADM_CORE_VIDEO_ENCODER_H

+#include "ADM_default.h"
#include "ADM_coreVideoEncoder6_export.h"
#include "ADM_coreVideoFilter.h"
#include "ADM_bitstream.h"


or

Code Select Expand

diff --git a/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoder.h b/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoder.h
index 5f39efe4..4267d726 100644
--- a/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoder.h
+++ b/avidemux_core/ADM_coreVideoEncoder/include/ADM_coreVideoEncoder.h
@@ -59,7 +59,7 @@ protected:
public:
                             ADM_coreVideoEncoder(ADM_coreVideoFilter *src);
virtual                     ~ADM_coreVideoEncoder();
-virtual        bool         setup(void) {ADM_info("[videoEncoder] Using default setup , i.e. no setup.\n");return true;}    /// Call once before using           
+virtual        bool         setup(void) {return true;}    /// Call once before using
virtual        bool         encode (ADMBitstream * out)=0;

virtual        bool         isDualPass(void) {return false;}

to fix the build for now.

[eumagga0x2a]

Mean has pushed the fix to the git master.

[Jan Gruuthuse]

Fixed: ae36e2b            [core] Fix compilation breakage