Avidemux Forum

Avidemux => MacOSX => Topic started by: riji on September 14, 2016, 10:49:49 am

Title: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 14, 2016, 10:49:49 am
Update: with 2.6.13  (160908_897a70c5954) a long time bug is back:
I can't use hotkey CMD-V to paste a file name at "Select file to save"
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 23, 2016, 11:50:57 am
sorry, something wrong with my question?
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: mean on September 23, 2016, 12:01:01 pm
Not looked at yet
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 23, 2016, 12:07:04 pm
PASTE =  CTRL-V in Windows   =   CMD-V in macOS (OS X)
I can use "Paste" from the menu, but not hotkey  CMD-V.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: Jan Gruuthuse on September 23, 2016, 04:01:22 pm
and what does it say for the short cut (in gray next to paste, linux it says Ctrl+V))
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 23, 2016, 08:43:26 pm
There are no shortcuts available:

Title: appmenu-qt5 and shortcuts
Post by: Jan Gruuthuse on September 24, 2016, 06:43:32 am
Possible to do with QT5?
On linux: QT5 shortcut not showing (http://avidemux.org/smif/index.php/topic,16956.0.html)
The current solution was to check what appmenu-qt is installed and remove appmenu-qt5.

Dev(s) can you check up on this: have shortcuts working with appmenu-qt5?
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 24, 2016, 09:33:41 am
Thanks, too difficult for me, I'll wait for a fix.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: eumagga0x2a on September 24, 2016, 01:28:39 pm
This sounds an awful lot like Qt bug 17291 (https://bugreports.qt.io/browse/QTBUG-17291).

riji, does this issue persist with Avidemux 2.6.14? Avidemux 2.6.14 release for Mac was built with quite recent Qt 5.6.1 (I don't know which version was used when compiling 2.6.13). Do you use English for your environment on Mac, including keyboard layout? Some comments in the bug report suggest the issue to be restricted to non-en locales.

This bug is probably a pure Qt bug, unlike the Ubuntu-only issue with appmenu-qt5 which affected keyboard shortcuts within the application, not related to native modal dialogs like the file picker or to context menus for text input fields.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: eumagga0x2a on September 24, 2016, 01:53:49 pm
Quote from: eumagga0x2a on September 24, 2016, 01:28:39 pm
riji, does this issue persist with Avidemux 2.6.14? Avidemux 2.6.14 release for Mac was built with quite recent Qt 5.6.1 (I don't know which version was used when compiling 2.6.13).


Please scratch that. Found the .dmg for 2.6.13 on SourceForge and looked into it: it uses the same Qt 5.6.1. So don't expect changes with respect to this particular issue.

Nevertheless, I strongly recommend to use 2.6.14 instead of earlier releases.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: eumagga0x2a on September 24, 2016, 02:32:15 pm
Quote from: eumagga0x2a on September 24, 2016, 01:28:39 pm
This bug is probably a pure Qt bug, unlike the Ubuntu-only issue with appmenu-qt5 which affected keyboard shortcuts within the application, not related to native modal dialogs like the file picker or to context menus for text input fields.


Actually, this seems to be more complicated and Jan was very much on it asking for shortcuts shown in the Edit menu, because commenters in the bug report mention that on Mac an application has to provide standard menu items with standard shortcuts to make them work in the native QFileDialog with fixed Qt version! Unfortunately, riji misunderstood the request and attached a wrong screenshot.

As far as I understand, Avidemux uses a custom menu, and I have no idea which implications this may have in respect to QFileDialog.

riji, would you attach a screenshot of the Edit menu in Avidemux on Mac, please?
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 24, 2016, 03:27:19 pm
I use version 2.6.13  (160821_4478db52b32).
The bug being not able to use shortcuts (CMD-V) with "Save file as" has been there for a very long time, but it was solved maybe some months ago and now it's back.
Attached is a screen capture of the Edit menu (OK).
It's when I want to save a file that the shortcuts disappear (see previous image).
I have update to version 2.6.14: problem persists.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: eumagga0x2a on September 24, 2016, 03:57:37 pm
Quote from: riji on September 24, 2016, 03:27:19 pm
The bug being not able to use shortcuts (CMD-V) with "Save file as" has been there for a very long time, but it was solved maybe some months ago and now it's back.


Is it feasible for you to identify the last Avidemux version where the keyboard shortcuts in the text input field of the file picker worked, please? While http://avidemux.org/nightly/osx_qt5/ (http://avidemux.org/nightly/osx_qt5/) hosts just a few most recent nightly builds, there is an archive of previous releases on SourceForge https://sourceforge.net/projects/avidemux/files/avidemux/ (https://sourceforge.net/projects/avidemux/files/avidemux/). However, older releases may be incompatible with the current Mac OS X version.

QuoteAttached is a screen capture of the Edit menu (OK).


Thanks, all shortcuts are present, though I don't know if it matters that the menu in Avidemux is custom built.

QuoteIt's when I want to save a file that the shortcuts disappear (see previous image).


I've got this, the thing is called file picker and is provided by the QFileDialog class.

QuoteI have update to version 2.6.14: problem persists.


As expected. Thanks.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 24, 2016, 04:29:15 pm
This version was OK, although I didn't have shortcuts in the menu available either, but CMD-V was working

Avidemux2.6_r2016_04_01_68a8f4989e6.dmg

Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: eumagga0x2a on September 24, 2016, 04:40:59 pm
Thanks, do you know by chance if it was a Qt5 or a Qt4 build? One can find this info among others in Avidemux2.6.app/Contents/Frameworks/QtCore.framework/Versions/ (I don't know how to accomplish this on Mac, on Linux you just extract the .dmg with 7z and descend into the "Avidemux2" folder). If there is a "4" folder, it is Qt4, if "5" it is Qt5.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 24, 2016, 06:06:22 pm
qt5...
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: eumagga0x2a on September 24, 2016, 06:34:45 pm
Thanks a lot, could you please as the last request test whether...

Quote from: eumagga0x2a on September 24, 2016, 01:28:39 pm
Do you use English for your environment on Mac, including keyboard layout? Some comments in the bug report suggest the issue to be restricted to non-en locales.


...switching the language of the desktop environment and the keyboard layout from Italian(?) to English makes a difference here.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 24, 2016, 07:32:47 pm
I use keyboard: Belgium (azerty), language: dutch
switched to: USA, English
no difference
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: eumagga0x2a on September 24, 2016, 08:03:23 pm
Thanks, we have now a very rough regression range 2016-04-01 (68a8f4989e6) (works) ââ,¬â€œ 2016-09-08 (897a70c5954) (fails) which amounts to more than 460 commits to choose from and have ruled out locale as a factor. Now it is up to the Author to find some time (or not to find any time) to look into it. The issue is IMVHO minor but somewhat exotic.

If you later manage to further reduce the range and to check the exact Qt5 version in Avidemux2.6.app/Contents/Frameworks/QtCore.framework/Versions/5/Resources/Info.plist, it would not harm either.
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: riji on September 25, 2016, 10:41:59 am
Avidemux2.6.app/Contents/Frameworks/QtCore.framework/Versions/5/Resources/Info.plist
Title: Re: 2.6.13 (160908_897a70c5954): bug: no hotkey CMD-V
Post by: eumagga0x2a on September 25, 2016, 10:56:18 am
Thank you, the working Avidemux version was built using an older Qt5 release: 5.6.0. If someone could build the current Avidemux source with that Qt5 version it would clearly show whether Qt or Avidemux is at fault.