Avidemux Forum

Avidemux => Main version 2.6 => Topic started by: ajschult on January 26, 2019, 03:24:53 AM

Title: RPMs built with CPack broken
Post by: ajschult on January 26, 2019, 03:24:53 AM
Now that avidemux installs xdg metadata (https://github.com/mean00/avidemux2/pull/175 (https://github.com/mean00/avidemux2/pull/175)) the building of RPMs (./bootStrap.bash --rpm) is broken.  The resulting avidemux3-qt5 RPM thinks that it owns the directories:

/usr/share/applications
/usr/share/icons
/usr/share/metainfo
/usr/share/icons/hicolor/128x128
/usr/share/icons/hicolor/128x128/apps
/usr/share/icons/hicolor
/usr/share/icons/hicolor
/usr/share/icons/hicolor/128x128
/usr/share/icons/hicolor/128x128/apps

But these are already owned by other packages on my system (Fedora 29).  Actually, that by itself does not seem to be a fatal problem (2 different packages own /usr/share/icons/hicolor), but the avidemux RPM wants the permissions to be different (drwxrwxr-x) from what the fedora packages have (drwxr-xr-x) and the difference in permissions apparently prevents the avidemux RPM from being installed (at least without --force).

I attempted to fix this via  CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION (https://cmake.org/cmake/help/v3.6/module/CPackRPM.html (https://cmake.org/cmake/help/v3.6/module/CPackRPM.html)), but without success.
Title: Re: RPMs built with CPack broken
Post by: eumagga0x2a on January 26, 2019, 10:18:50 AM
The first thing I do on Fedora is to fix the default umask and set it to 0022. With this task done, CPack generated Avidemux RPMs install and run fine.
Title: Re: RPMs built with CPack broken
Post by: ajschult on January 30, 2019, 12:20:35 AM
Perhaps.  But that doesn't mean the CPack RPM build isn't broken.
Title: Re: RPMs built with CPack broken
Post by: eumagga0x2a on January 30, 2019, 07:09:15 PM
You're right, should be fixed (https://github.com/mean00/avidemux2/commit/6860e61fa1ef12a718cd7448003e9ce4a744ee22) now. Thank you for raising the issue.