Avidemux Forum

Avidemux => Windows => Topic started by: me444 on May 16, 2021, 07:42:01 PM

Title: User choice about position and size of the ADM main window?
Post by: me444 on May 16, 2021, 07:42:01 PM
Hello eumagga0x2a,

here it's mentioned that with newer builds the program window behaviour was changed, "now, if the video resolution is big enough, the window maximizes to entire monitor (or until it touches on of the edges"
https://avidemux.org/smif/index.php/topic,19534.0.html

Since a long time i do not have any problems with ADM at all, really none. But this new behaviour i find very annoying and a burden for my work.
Yes, it's a very personal preference and maybe a question of flavour, but i'm used that i myself decide which size and position the application window should have.
Whereas now the app decides to (under certain circumstances) occoupy nearly the whole screen and, so, makes other apps disappear from the screen. Not good!

And it might be hard to find the edges with the mouse and to drag the window back to the position and size it is expected to have, an action, that the app does not respect, sigh ...

Not quite sure whether you want to express that this behaviour still needs to be modified somehow later ?  "Now just a zoom level indicator is missing."

I would highly vote and wish very much that this new behaviour at least should be an option.
At least the left and top position should be possible to be preserved and respected when the app tries to expand.

Please let the user decide if he likes this special change or not (i do not like it at all ... it does drive me crazy).
Hopefully a not so strict solution can be found.

With kind Regards from a friend of this very wonderful and amazing application!

Title: Re: User choice about position and size of the ADM main window?
Post by: butterw on May 16, 2021, 09:56:47 PM
IMO it could be a preference setting, but the new v2.7.9 window resizing should be the default.
Title: Re: User choice about position and size of the ADM main window?
Post by: eumagga0x2a on May 16, 2021, 09:57:44 PM
No GUI change can satisfy everyone. Please press 4 or 3 after loading a video too large to fit into screen to force a power-of-two zoom level (1/4 or 1/2) which was the old behaviour regarding zoom.

Quote from: me444 on May 16, 2021, 07:42:01 PMNot quite sure whether you want to express that this behaviour still needs to be modified somehow later ?  "Now just a zoom level indicator is missing."

This means that I want to be able to find out the current zoom level instantly from Avidemux GUI, without reading the log.
Title: Re: User choice about position and size of the ADM main window?
Post by: me444 on May 16, 2021, 11:07:15 PM
Hello eumagga0x2a,

kind thanks for your attention!
"it could be a preference setting, but the new v2.7.9 window resizing should be the default."  ---> No problem at all :-)

"No GUI change can satisfy everyone".
Yes, my full commitment, fully aware of that. The more one should be careful to implement such drastic change as mandatory behaviour for all.
It's so much against the Windows philosophy, that i even find it hard to identify, amongst a lot of apps, a single one that still goes fullscreen so massively and does not respect the other habitants of the screen so heavy.  --- Vote for an option, with pleasure a non-defaulted one.

4 or 3 on the numeric keypad: the first i tried. It's broken for me too.
4 does nothing; 3 lets jump the B marker to the end of the file  (Windows 10 x64; avidemux_r210510_win64Qt5_63.zip) ... no benefit at all.

Do you see a chance to make it an non-defaulted option?
Title: Re: User choice about position and size of the ADM main window?
Post by: dosdan on May 17, 2021, 04:03:03 AM
Quote from: me444 on May 16, 2021, 11:07:15 PM4 or 3 on the numeric keypad: the first i tried. It's broken for me too.
4 does nothing; 3 lets jump the B marker to the end of the file  (Windows 10 x64; avidemux_r210510_win64Qt5_63.zip) ... no benefit at all.

Sounds like you do either do not have Numlock On or the PC is confused about the keyboard status. Those actions you mentioned occur if you press numeric keypad 4 or 3 with Numlock Off.

Try 4 or 3 along the top of keyboard.

Dan.
Title: Re: User choice about position and size of the ADM main window?
Post by: butterw on May 17, 2021, 08:29:16 AM
"3" works for me from keypad or top of keyboard.

! I've noticed the following display issue:
pressing 2 (zoom 1x) causes the window controls to get hidden behind the taskbar. Also happens for zoom 2x.
steps to reproduce:
- Avidemux Win64 2.7.9-Mai on Win10
- 1080p video loaded on a 1080p display
- the window isn't maximised



 
Title: Re: User choice about position and size of the ADM main window?
Post by: me444 on May 17, 2021, 08:44:06 AM
Numlock ... i use the 4, 3 oftenly, but in this case it was inded on, uh, right. My error!
Now it docks at the left side, where i do not want to have it  - another app is already here.

But this is not the point. A Windows app should be able to restart with position and size i left it. That's what all Windows apps are doing.
What would you feel if you start a word processor and it starts .. fullscreen. Allowing keystroke-x to change.
After that: Excel - full screen. Allowing keystroke-y to change. Text Editor? Full screen: keystroke-a. File explorerer? Full screen; keystroke-b.
Icon Editor, programming IDE, Paint program, video player video editor, Browser   ... maximized. Control panel .. full screen.  What would you feel? None of them are doing so.
If there is any chance to make an option for to keep the previous behaviour?

After being a happy adm user since over ten years that's the first and only time i heavily disagree with a design decision. I really don't want to use the app like such,
So i would be forced to stay at the last version forever or to find another editing tool instead. I'm  very unhappy about that, because adm is one of my favorite apps.
Title: Re: User choice about position and size of the ADM main window?
Post by: eumagga0x2a on May 17, 2021, 10:01:44 AM
Quote from: butterw on May 17, 2021, 08:29:16 AM! I've noticed the following display issue:
pressing 2 (zoom 1x) causes the window controls to get hidden behind the taskbar. Also happens for zoom 2x.

Window controls? You probably mean the navigation widget & Co. I don't think anything can and should be done about it, and the behaviour is not consistent across different platforms (on Linux/gnome-shell, the navigation widget overlays the bottom part of the video if the zoom pushes parts of the Avidemux window out of the screen boundaries).

Quote from: me444 on May 17, 2021, 08:44:06 AMA Windows app should be able to restart with position and size i left it. That's what all Windows apps are doing.

Avidemux never followed this paradigm. It always tried to occupy as little space as possible, unless the window is maximized (Avidemux doesn't support fullscreen, and never had). Therefore it always derived its window size from the size and zoom level of video preview. If the video is too large to be displayed 1:1, the default zoom level will be reduced to a float value based on the available screen size. The old behaviour limited available default zoom levels to 100%, 50% and 25% only, which was really bad when 25% was not small enough. The new one just removed this limitation.

Of course, I don't rule out that an infrastructure to preserve window size and widget state (especially widget state) will be developed in the future, allowing a policy change.
Title: Re: User choice about position and size of the ADM main window?
Post by: me444 on May 17, 2021, 10:40:16 AM
QuoteAvidemux never followed this paradigm
Hi eumagga0x2a, yes,i'm fully aware of that, but it ever had been a good compromise one could comfortably live with.
 
Whereas now it is a obvious und unmistakable break of the rules how Windows apps should behave; with other words: how user might be used to work with.
It's my strong belief that an app must not be so dominant regarding the occupation of the screen area for itself.
Title: Re: User choice about position and size of the ADM main window?
Post by: butterw on May 17, 2021, 11:20:21 AM
Quote from: eumagga0x2a on May 17, 2021, 10:01:44 AM
Quote from: butterw on May 17, 2021, 08:29:16 AM! I've noticed the following display issue:
pressing 2 (zoom 1x) causes the window controls to get hidden behind the taskbar. Also happens for zoom 2x.

Window controls? You probably mean the navigation widget & Co. I don't think anything can and should be done about it, and the behaviour is not consistent across different platforms (on Linux/gnome-shell, the navigation widget overlays the bottom part of the video if the zoom pushes parts of the Avidemux window out of the screen boundaries).

It hides the part of the window which is behind the taskbar. It is only really a problem if the Windows taskbar is at the top of the screen and it works if the taskbar is set to autohide.

On the subject of GUI preferences, one thing I've noticed is that the recent files list is limited to 4 items, which is very unsufficient for me. Is there a configuration option for this ?


Title: Re: User choice about position and size of the ADM main window?
Post by: eumagga0x2a on May 17, 2021, 11:39:10 AM
Quote from: butterw on May 17, 2021, 11:20:21 AMone thing I've noticed is that the recent files list is limited to 4 items, which is very unsufficient for me. Is there a configuration option for this ?

The maximum number of recent files and projects is limited by the size of the lastfiles and lastprojects structures in preferences (in my_prefs_struct) respectively. I do like short menus, but in this case I have to admit that it feels a bit at the low end.
Title: Re: User choice about position and size of the ADM main window?
Post by: eumagga0x2a on May 17, 2021, 11:43:30 AM
Quote from: butterw on May 17, 2021, 11:20:21 AMIt hides the part of the window which is behind the taskbar. It is only really a problem if the Windows taskbar is at the top of the screen and it works if the taskbar is set to autohide.

Thank you for clarification. Does Windows have anything similar to the feature of mutter in gnome-shell (present in many other window managers) where you can grab and drag an application window at any point by keeping a specified key (Super, Meta or Alt) pressed?
Title: Re: User choice about position and size of the ADM main window?
Post by: butterw on May 17, 2021, 12:27:01 PM
Quote from: eumagga0x2a on May 17, 2021, 11:39:10 AM
Quote from: butterw on May 17, 2021, 11:20:21 AMone thing I've noticed is that the recent files list is limited to 4 items, which is very unsufficient for me. Is there a configuration option for this ?

The maximum number of recent files and projects is limited by the size of the lastfiles and lastprojects structures in preferences (in my_prefs_struct) respectively. I do like short menus, but in this case I have to admit that it feels a bit at the low end.

I tried to extend lastfiles in config3 with a "file5" entry but it wasn't displayed, and was overwritten by Avidemux.
It's also not clear to me why a number is displayed in the GUI before the filename (they are displayed in last opened order).


Title: Re: User choice about position and size of the ADM main window?
Post by: butterw on May 17, 2021, 12:39:21 PM
Quote from: eumagga0x2a on May 17, 2021, 11:43:30 AM
Quote from: butterw on May 17, 2021, 11:20:21 AMIt hides the part of the window which is behind the taskbar. It is only really a problem if the Windows taskbar is at the top of the screen and it works if the taskbar is set to autohide.

Thank you for clarification. Does Windows have anything similar to the feature of mutter in gnome-shell (present in many other window managers) where you can grab and drag an application window at any point by keeping a specified key (Super, Meta or Alt) pressed?

On Windows10, You can use Windows + arrow shortcuts.
Most users would likely use the control buttons on the window controls or double click on the titlebar to maximise.
This issue isn't new, it is present in 2.7.1.

Having a "don't resize window, keep window size" user preference would make sense.
Title: Re: User choice about position and size of the ADM main window?
Post by: eumagga0x2a on May 17, 2021, 12:58:22 PM
The struct is defined here (https://github.com/mean00/avidemux2/blob/3753f57bb4be724ae222182c27666f87d2b68e22/avidemux_core/ADM_coreUtils/src/prefs2.conf#L62), i.e. it is hardcoded.

Quote from: butterw on May 17, 2021, 12:27:01 PMIt's also not clear to me why a number is displayed in the GUI before the filename (they are displayed in last opened order).

To serve the purpose, it should be possible to select an entry by typing the number. It is not yet implemented.

Quote from: butterw on May 17, 2021, 12:39:21 PMOn Windows10, You can use Windows + arrow shortcuts.

So keyboard-only, nothing equivalent to "grab anywhere, drag anywhere" feature on Linux? Does it at least allow to push a window beyond the screen boundaries (and bring it back)?

Quote from: butterw on May 17, 2021, 12:39:21 PMMost users would likely use the control buttons on the window controls or double click on the titlebar to maximise.

This is actually not about maximizing and unmaximazing. It is about screen estate usage, and I do understand that it feels somewhat intrusive when an application uses all the available space to display its content. However, with keys 3 and 4 (I didn't mean the number pad, else I would have mentioned that) always in reach, it would not be a problem at all. Alas, my fix for the window placement issue (https://github.com/mean00/avidemux2/commit/82a7fcd15fd32199514772beea62c091d736fad) spoils the situation, as it won't (and should not) move Avidemux window back to the middle of the screen.
Title: Re: User choice about position and size of the ADM main window?
Post by: butterw on May 17, 2021, 02:25:42 PM
Windows + arrow keys are maximize/snap hotkeys.
The usual way to move a window is by dragging the titlebar, however in this case it could be completely inacessible if the taskbar is at the top of the screen. This would be uncommon.

I'm seeing a different issue with portrait mode sources larger than the screen. This is with the window maximized so it is a zoom issue: the image gets stretched (wrong display AR) when using 1 or 2.

Title: Re: User choice about position and size of the ADM main window?
Post by: eumagga0x2a on May 17, 2021, 04:26:51 PM
Quote from: butterw on May 17, 2021, 02:25:42 PMThe usual way to move a window is by dragging the titlebar, however in this case it could be completely inacessible if the taskbar is at the top of the screen.

Exactly the problem addressed by the feature of many window managers on Linux to allow to grab and drag a window at any point, not only at the titlebar = a titlebar pushed out of reach is a serious usability issue for Windows. Regarding taskbar at the top, I'll need to recheck the window repositioning code (when Y axis is counted by Qt from the physical top edge rather than from the bottom edge of the top-placed taskbar, we have a problem), this possibility was definitely never considered during development and testing.

Quote from: butterw on May 17, 2021, 02:25:42 PMI'm seeing a different issue with portrait mode sources larger than the screen. This is with the window maximized so it is a zoom issue: the image gets stretched (wrong display AR) when using 1 or 2.

I cannot reproduce this issue on Linux (tried with a portrait-mode 4k sample on a FullHD display), will need to recheck on Windows. However, if a zoom level is too high for the picture to fit into available space, the result will be broken this way or the other. I don't know whether it is worth the effort.
Title: Re: User choice about position and size of the ADM main window?
Post by: butterw on May 17, 2021, 05:09:33 PM
Quote from: eumagga0x2a on May 17, 2021, 04:26:51 PM
Quote from: butterw on May 17, 2021, 02:25:42 PMThe usual way to move a window is by dragging the titlebar, however in this case it could be completely inacessible if the taskbar is at the top of the screen.

Exactly the problem addressed by the feature of many window managers on Linux to allow to grab and drag a window at any point, not only at the titlebar = a titlebar pushed out of reach is a serious usability issue for Windows. Regarding taskbar at the top, I'll need to recheck the window repositioning code (when Y axis is counted by Qt from the physical top edge rather than from the bottom edge of the top-placed taskbar, we have a problem), this possibility was definitely never considered during development and testing.

You might need platform specific code to handle Windows correctly. The Win10 taskbar is always on top (I have it on the left side of screen).

Quote from: eumagga0x2a on May 17, 2021, 04:26:51 PM
Quote from: butterw on May 17, 2021, 02:25:42 PMI'm seeing a different issue with portrait mode sources larger than the screen. This is with the window maximized so it is a zoom issue: the image gets stretched (wrong display AR) when using 1 or 2.

I cannot reproduce this issue on Linux (tried with a portrait-mode 4k sample on a FullHD display), will need to recheck on Windows. However, if a zoom level is too high for the picture to fit into available space, the result will be broken this way or the other. I don't know whether it is worth the effort.

Wrong AR looks ugly. The AR issue also persists to some extent after you've zoomed back out so that the image fits in the screen.
Needs reproducing, figuring out and should be easy to fix.


 
Title: Re: User choice about position and size of the ADM main window?
Post by: eumagga0x2a on May 18, 2021, 07:56:01 PM
I see, the problem with wrong AR when zoomed picture becomes too big to fit into available space in Avidemux window affects the unaccelerated Qt output only (i.e. it is impossible to draw stuff larger than canvas). All other outputs are fine, so no big deal.

Regarding Y with the taskbar at the top (at the top edge of the screen), Qt indeed counts from the screen edge, which results in the titlebar hidden behind the taskbar. The same probably applies to the setup with taskbar at the left.
Title: Re: User choice about position and size of the ADM main window?
Post by: eumagga0x2a on May 18, 2021, 10:51:38 PM
The collision with the taskbar should be fixed by [1] (https://github.com/mean00/avidemux2/commit/8a9f4d974854510680dd6f4e8bf15ab2b7aac1d8) + [2] (https://github.com/mean00/avidemux2/commit/02aa7ceed4e09f52706e7a40389fa6816756c7f0), thank you for your report.