Author Topic: [not just cosmetics] Lower case for Webm muxer  (Read 693 times)

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3192
[not just cosmetics] Lower case for Webm muxer
« on: September 26, 2016, 07:10:50 PM »
Due to the file name extension filter in the QFileDialog matching verbatim against the first element in ADM_MUXER_BEGIN, the current spelling of webm as "Webm" in avidemux_plugins/ADM_muxers/muxerWebm/muxerWebmPlugin.cpp:24 poses a problem in case-sensitive environments like Linux, as the file picker would not show existing .webm files and would suggest ".Webm" as file name extension for the video. The most simple way to avoid this inconvenience would be to spell WebM lower case.

Code: [Select]
diff --git a/avidemux_plugins/ADM_muxers/muxerWebm/muxerWebmPlugin.cpp b/avidemux_plugins/ADM_muxers/muxerWebm/muxerWebmPlugin.cpp
index 94c9c05..4174bc3 100644
--- a/avidemux_plugins/ADM_muxers/muxerWebm/muxerWebmPlugin.cpp
+++ b/avidemux_plugins/ADM_muxers/muxerWebm/muxerWebmPlugin.cpp
@@ -21,7 +21,7 @@
 #include "fourcc.h"
  bool WebmConfigure(void);
 
-ADM_MUXER_BEGIN( "Webm",muxerWebm,
+ADM_MUXER_BEGIN( "webm",muxerWebm,
                     1,0,0,
                     "Webm",    // Internal name
                     "Webm muxer plugin (c) Mean 2009",