** Failed at make, result in /tmp/logbuildCore**

Started by Jan Gruuthuse, October 04, 2016, 06:22:52 AM

Previous topic - Next topic

Jan Gruuthuse

fixed: (e4c2251)    [libVa] Remove some va encoding stuff for now

/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:170:9: error: ââ,¬ËœVAEncPictureParameterBufferH264ââ,¬â,,¢ was not declared in this scope
         VAEncPictureParameterBufferH264 pic_h264;
         ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:170:41: error: expected ââ,¬Ëœ;ââ,¬â,,¢ before ââ,¬Ëœpic_h264ââ,¬â,,¢
         VAEncPictureParameterBufferH264 pic_h264;
                                         ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:184:43: error: ââ,¬Ëœpic_h264ââ,¬â,,¢ was not declared in this scope
                                    sizeof(pic_h264),1,&pic_h264,&pic_param_buf));
                                           ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA.cpp:89:32: note: in definition of macro ââ,¬ËœCHECK_ERRORââ,¬â,,¢
#define CHECK_ERROR(x) {xError=x;displayXError(#x,ADM_coreLibVA::display,xError);}
                                ^
make[2]: *** [ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/CMakeFiles/ADM_coreLibVA6.dir/ADM_coreLibVA.cpp.o] Error 1
make[2]: Leaving directory `/home/jan/avidemux2/buildCore'
make[1]: *** [ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/CMakeFiles/ADM_coreLibVA6.dir/all] Error 2

_____________________________________________
Avidemux v2.6.14 (e0e526a)    [AudioEncoder] Skeleton for fdk-aac
_____________________________________________
Compiler: GCC 4.8.4
cmake: 2.8.12.2
Build Target: Linux (x86-64)
User Interface: Qt (4.8.6)
_____________________________________________
Kernel: Linux 3.19.0-69-generic (x86_64) (linux-image-3.19.0-68-generic                         3.19.0-68.76~14.04.1)
Distribution: Linux Ubuntu 14.04.5 LTS (Trusty)
qt4-default: installed
qt5-default: not installed
_____________________________________________

Intel Core i7-3770K @ 3.50GHz (4 Cores/8 Threads) with 32 GB ram

Desktop: Unity 7.2.6
Display Server: X Server 1.15.1
Display Driver: NVIDIA 352.99
OpenGL: 4.3.0
Compiler: GCC 4.8.4 + CUDA 7.5


OpenGL Vendor: NVIDIA Corporation
OpenGL Renderer: GeForce GTX 960/PCIe/SSE2 2048MB (1227/3600MHz)
OpenGL: 4.5.0 NVIDIA 352.99


- vdpauinfo:API version: 1   NVIDIA VDPAU Driver Shared Library  352.99
- x264 0.148.2705 3f5ed56
(libswscale 3.1.101)
(libavformat 56.36.100)
x264 configuration: --bit-depth=8 --chroma-format=all
libx264 configuration: --bit-depth=8 --chroma-format=all


- x265 [info]: HEVC encoder version 1.9+226-6561d8676581
x265 [info]: build info [Linux][[GCC 4.8.4][64 bit] 8bit
_____________________________________________

Jan Gruuthuse

#1
736b56a [audioEncoder/fdk] Fix up include and libs
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:170:9: error: ââ,¬ËœVAEncPictureParameterBufferH264ââ,¬â,,¢ was not declared in this scope
         VAEncPictureParameterBufferH264 pic_h264;
         ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:170:41: error: expected ââ,¬Ëœ;ââ,¬â,,¢ before ââ,¬Ëœpic_h264ââ,¬â,,¢
         VAEncPictureParameterBufferH264 pic_h264;
                                         ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:184:43: error: ââ,¬Ëœpic_h264ââ,¬â,,¢ was not declared in this scope
                                    sizeof(pic_h264),1,&pic_h264,&pic_param_buf));
                                           ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA.cpp:89:32: note: in definition of macro ââ,¬ËœCHECK_ERRORââ,¬â,,¢
#define CHECK_ERROR(x) {xError=x;displayXError(#x,ADM_coreLibVA::display,xError);}
                                ^
make[2]: *** [ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/CMakeFiles/ADM_coreLibVA6.dir/ADM_coreLibVA.cpp.o] Error 1
make[2]: Leaving directory `/home/jan/avidemux2/buildCore'
make[1]: *** [ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/CMakeFiles/ADM_coreLibVA6.dir/all] Error 2

eumagga0x2a

This could be related to [VA] Better probe of encoding capabilities (incomplete). By the way, the current git master compiles fine with libva 1.7.2 for me.

A déjà-vu of http://avidemux.org/smif/index.php/topic,17165.0.html?

Jan Gruuthuse

Quote from: eumagga0x2a on October 04, 2016, 07:37:56 AM
By the way, the current git master compiles fine with libva 1.7.2 for me.
That's on 16.04, not available on 14.04.5?

eumagga0x2a

No, at least not without some handiwork.

By the way, it is great that you keep building Avidemux on 14.04.x, without your testing such build issues with older libs would go undetected.

eumagga0x2a

Could you please try building on 16.04.x? Actually, VAEncPictureParameterBufferH264 is defined in /usr/include/va/va_enc_h264.h on Ubuntu 14.04.x as well, so I am not sure the libva version matters here.

Jan Gruuthuse

Quote from: eumagga0x2a on October 04, 2016, 10:37:29 AM
Actually, VAEncPictureParameterBufferH264 is defined in /usr/include/va/va_enc_h264.h on Ubuntu 14.04.x as well, so I am not sure the libva version matters here.
It is in that location, does that suffice for avidemux?
pic_h264 is avidemux defined value? pic_h264 is not in VAEncPictureParameterBufferH264. VAPictureH264   CurrPic; is.

eumagga0x2a

#7
Quote from: Jan Gruuthuse on October 04, 2016, 01:36:03 PM
Quote from: eumagga0x2a on October 04, 2016, 10:37:29 AM
Actually, VAEncPictureParameterBufferH264 is defined in /usr/include/va/va_enc_h264.h on Ubuntu 14.04.x as well, so I am not sure the libva version matters here.
It is in that location, does that suffice for avidemux?

No, not in the libva-dev package provided by Ubuntu 14.04.x ;)
In later versions va_enc_h264.h is included in va.h and thus picked up by Avidemux.

Quotepic_h264 is avidemux defined value?

Yes, in my still very limited understanding of C++, this is the Avidemux-defined name for a variable (set of variables) of the type defined by VAEncPictureParameterBufferH264. It is also a bit shorter and easier to write :)

mean

The proper fix is to separate vadecoding from vaencoding and only do interesting encoding stuff if vaencoding is recent enough
That will make it work, no eta for that





Jan Gruuthuse

fed4ef7       [audioEncoder] Actually calling the FDK functions
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:170:9: error: ââ,¬ËœVAEncPictureParameterBufferH264ââ,¬â,,¢ was not declared in this scope
         VAEncPictureParameterBufferH264 pic_h264;
         ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:170:41: error: expected ââ,¬Ëœ;ââ,¬â,,¢ before ââ,¬Ëœpic_h264ââ,¬â,,¢
         VAEncPictureParameterBufferH264 pic_h264;
                                         ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA_encoder.cpp:184:43: error: ââ,¬Ëœpic_h264ââ,¬â,,¢ was not declared in this scope
                                    sizeof(pic_h264),1,&pic_h264,&pic_param_buf));
                                           ^
/home/jan/avidemux2/avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA.cpp:89:32: note: in definition of macro ââ,¬ËœCHECK_ERRORââ,¬â,,¢
#define CHECK_ERROR(x) {xError=x;displayXError(#x,ADM_coreLibVA::display,xError);}
                                ^
make[2]: *** [ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/CMakeFiles/ADM_coreLibVA6.dir/ADM_coreLibVA.cpp.o] Error 1
make[2]: Leaving directory `/home/jan/avidemux2/buildCore'
make[1]: *** [ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/CMakeFiles/ADM_coreLibVA6.dir/all] Error 2

eumagga0x2a

Unless VA decoder and VA encoder are separated and detection of suitable libva versions for the latter is implemented, the build on 14.04.x will fail, obviously. If you want to build on 14.04.x right now, you must revert [VA] Better probe of encoding capabilities (incomplete) patch locally.

mean

I've commented out the offending part, it might be enough for the moment