Author Topic: Zoom video to window, is it so hard?  (Read 1970 times)

Owyn

  • Newbie
  • *
  • Posts: 3
Zoom video to window, is it so hard?
« on: August 03, 2017, 07:40:54 PM »
There are tons of optioms for zoom in the menu... 1:1, 1:2, 1:4... but no option to zoom to window size?? really?

Please implement this.

2.6.21

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: Zoom video to window, is it so hard?
« Reply #1 on: August 03, 2017, 08:56:18 PM »
Video display is automatically zoomed to the available size of the window on resizing. No option in the menu though (is it really necessary?). Please try a current nightly build, the last release is quite outdated.

Owyn

  • Newbie
  • *
  • Posts: 3
Re: Zoom video to window, is it so hard?
« Reply #2 on: August 03, 2017, 11:34:12 PM »
Oh yes, this feature is present in nightly build

But it's so weird that it's not present in stable one (barely anyone rushes to install nighty)

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: Zoom video to window, is it so hard?
« Reply #3 on: August 04, 2017, 11:29:58 AM »
But it's so weird that it's not present in stable one (barely anyone rushes to install nighty)

Quite the opposite. The initial version of the "zoom on resize" feature was merged on June 3, long after 2.6.20 (2.6.21 for win64 only) was released. 2.7.0 will be released with this functionality and other improvements when appropriate.

Owyn

  • Newbie
  • *
  • Posts: 3
Re: Zoom video to window, is it so hard?
« Reply #4 on: November 07, 2019, 06:25:47 PM »
But it's so weird that it's not present in stable one (barely anyone rushes to install nighty)

Quite the opposite. The initial version of the "zoom on resize" feature was merged on June 3, long after 2.6.20 (2.6.21 for win64 only) was released. 2.7.0 will be released with this functionality and other improvements when appropriate.
I have 2.7.4 installed and the issue is still there
when you resize window manually - video also resizes, but
when you maximize the window - video size stays the same

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: Zoom video to window, is it so hard?
« Reply #5 on: November 07, 2019, 08:10:21 PM »
This should have been fixed by [mainWindow] Always zoom video on maximize, limit the scope of needsResizing to file, present in 2.7.4, there haven't been any further changes to this code and it works for me with git master upon a quick test on Linux:

1. Launch Avidemux.

2. Load a video (zoom is set to the maximum value with denominator being power of 2 which doesn't push parts of Avidemux GUI out of the available screen real estate).

3. Maximize Avidemux window.

Video zoom changes to a float value to fit increased available space.

Avidemux never upscales a video on load, this is by design. To zoom it to the available size in the window, the window must be resized (or the state changed between maximized and normal) beyond a certain small threshold.


eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: Zoom video to window, is it so hard?
« Reply #6 on: November 07, 2019, 08:19:18 PM »
...but confirmed with the latest nightly on Windows. The first maximizing step is still ignored, the window has to be normalized and maximized again to enable fit-to-window.

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: Zoom video to window, is it so hard?
« Reply #7 on: November 07, 2019, 11:58:29 PM »
The direct cause of the problem on Windows is the reversed order of resize event and window state change events relative to Linux. On Linux, the window state change signal (transitions between normalized, maximized and minimized states) is fired before the resize event, on Windows it is the other way round.

Seemingly trivial to fix, it turns out to be difficult to get all the details right.