Author Topic: avidemux crashes when saving edited files  (Read 1100 times)

giorel

  • Newbie
  • *
  • Posts: 6
avidemux crashes when saving edited files
« on: November 25, 2019, 06:34:39 PM »
for many years avidemux worked very well. now, a few months ago, perhaps due to some incompatibility with Windows updates (10 pro 64) very often in the save phase I receive the attached message. Can anyone explain it?
Thx

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #1 on: November 25, 2019, 09:23:24 PM »
This is possible when the priority of Avidemux process is set to realtime or another value not handled by the getpriority() function which results in an assert failure = a controlled crash.
« Last Edit: November 25, 2019, 09:26:15 PM by eumagga0x2a »

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #2 on: November 25, 2019, 10:49:41 PM »
This crash should not happen anymore, please try a future (dated 191126 or later) nightly build.

giorel

  • Newbie
  • *
  • Posts: 6
Re: avidemux crashes when saving edited files
« Reply #3 on: November 27, 2019, 12:58:36 AM »
no change by lowering the priority (which was actually real time)
where do I find the indication of the build and where do I find the builds?
Thx

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #4 on: November 27, 2019, 06:35:17 AM »
where do I find the builds?

Please follow the link  --> "win64"

The build with "r191126" in the filename (the same build is packaged as an .exe and as a .zip) includes already the patches* which hopefully solve the problem.

If the same assert failures happen with the new build, it means that the function GetPriorityClass() returns a different unexpected value and I'll add one more patch to catch it then.

*) [coreUI] Remove redundant second call to getpriority() in encoding dialog ctor and [core/win32] Do not crash on GetPriorityClass() failure or on REALTIME_PRIORITY_CLASS as return value.

giorel

  • Newbie
  • *
  • Posts: 6
Re: avidemux crashes when saving edited files
« Reply #5 on: November 28, 2019, 08:14:17 PM »
now it's even worse (see attachment). Furthermore, after I installed the program, apparently without reports, I can't find the program directory anymore!

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #6 on: November 28, 2019, 11:02:18 PM »
Looks like a borked installation. Did you install the MinGW build into the same directory as the VC++ one? This can't work and will result in all sorts of failures. Additionally, you should not run both versions simultaneously (no matter where installed) because they claim the same configuration files.

Remove all installed versions, then either install or just unpack the ZIP version of the MinGW nightly build.

giorel

  • Newbie
  • *
  • Posts: 6
Re: avidemux crashes when saving edited files
« Reply #7 on: November 29, 2019, 05:48:01 AM »
before installing the build I completely uninstalled all the versions I had of avidemux. But I used the build exe. I'll try with all the zip data. thanks

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #8 on: November 29, 2019, 01:37:56 PM »
Meanwhile, Mean has fixed logging in VC++ builds (the first build with the fix: r191129 from 10:29).

Due to other, unrelated fixes (loading mp4 with AC3 audio was broken, resulted in a crash), it may make sense to wait for next round of nightlies.

giorel

  • Newbie
  • *
  • Posts: 6
Re: avidemux crashes when saving edited files
« Reply #9 on: November 29, 2019, 02:07:13 PM »
as for my installation, everything as before, still crashing

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #10 on: November 29, 2019, 02:30:33 PM »
Still crashing in the very same way (assert failure with a sligtly different line number = 98) when opening encoding dialog? Or something different?

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #11 on: November 29, 2019, 02:46:25 PM »
I've added a debug message to log unexpeted priority classes. Please try a future nightly – a VC++ or a MinGW one and once it crashes due to assert failure in ADM_win32.cpp, compress (zip or 7z) and attach admlog.txt from %localappdata%\avidemux\ to your reply.

giorel

  • Newbie
  • *
  • Posts: 6
Re: avidemux crashes when saving edited files
« Reply #12 on: November 29, 2019, 05:56:36 PM »
exactly the same indication

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #13 on: November 29, 2019, 06:19:19 PM »
To be sure: which git revision (the 11 characters preceding "-fflibs") does your Avidemux build show in Help --> About?

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 4188
Re: avidemux crashes when saving edited files
« Reply #14 on: November 29, 2019, 09:22:36 PM »
A fresh VC++ build (191129 from Nov 29 2019 10:18 PM) with changes which would help to identify the problem has been uploaded --> https://avidemux.org/nightly/vsWin64/, please test and provide the admlog.txt after crash.