Author Topic: "2.7.5 r191130_win32" crash on drag-drop: bug or not?  (Read 470 times)

hiro

  • Jr. Member
  • **
  • Posts: 59
"2.7.5 r191130_win32" crash on drag-drop: bug or not?
« on: December 22, 2019, 05:33:49 AM »
Hi,

"avidemux_2.7.5 r191130_win32.exe (Nov 30 2019 7:18 AM)" quick test:

Bug or not? Sorry: I have no ADM log, neither a video sample to submit / been testing at a friend's & ran short of time.*

Anyway, that nightly crashed repeatedly, on Win. XP 32, when dropping an FFmpeg remuxed .mp4 vid onto it (perfectly functional, tested OK using "VLC, PotPlayer" + other ADM versions) — though accepting ADM 2.7.4 recoded vids...

* Back home: ADM 2.7.5 on Win. 10 64: no crash on similar but not on same exact vids.


.

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #1 on: December 22, 2019, 07:50:45 AM »
It is impossible to assess the issue with the information available. Can you get hold of the file which triggered the crashes?

Quote
* Back home: ADM 2.7.5 on Win. 10 64: no crash on similar but not on same exact vids.

At the moment, the latest official VC++ nightly is from Dec 21 2:43 PM, it is also a "2.7.5". I mean, 2.7.5 as version info alone is not very specific.

The general rule is always to test with the latest build and if it fails in some way to compare the results with the last release to check whether the problem was introduced by recent code changes.

hiro

  • Jr. Member
  • **
  • Posts: 59
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #2 on: December 24, 2019, 03:44:48 AM »
Thanks for the answer. No, can't be retrieved / I called the friends but the (heavy) file had already been recoded — on Win. 10 —, + deleted.

Well, never mind, I guess, as I was not able to reproduce the issue on my Win. XP PC. We'll just wait for the next 32-bit release — and TRY to avoid testing in a rush!..

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #3 on: December 24, 2019, 04:42:31 PM »
No, can't be retrieved / I called the friends but the (heavy) file had already been recoded — on Win. 10 —, + deleted.

That's a pity. Just preserving the admlog.txt from the crash might have given a clue about the nature of the problem.

Quote
We'll just wait for the next 32-bit release

Waiting for a release is the best recipe for keeping the bugs safe.

https://avidemux.org/nightly/win32/

The last nightly is from yesterday, Dec 23 2019. Please help to squish bugs and keep testing nightlies.

(Nevertheless, it would make a lot of sense to ditch Windows XP and move to 64 bits hardware and software.)

hiro

  • Jr. Member
  • **
  • Posts: 59
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #4 on: December 30, 2019, 03:06:00 PM »
While testing "avidemux_2.7.5 r191223_win32" / no problem so far:


About ditching Win. XP, + BTW "As of Sept. 2019, 1.54% of Windows PCs run Windows XP. (Google)",

well, of course — except for (amateur but) "mass reencoding", as friends + I can't always afford buying additional PCs;

in that case, we often let 2 to 4 of those antediluvian "boxes" grind overnight (or worse) [ though I haven't calculated "electricity bill vs. purchasing new / faster equipment" costs, "yet"?.. ].



eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #5 on: December 30, 2019, 05:20:15 PM »
While testing "avidemux_2.7.5 r191223_win32" / no problem so far:

While running on Windows XP? It should be easily possible to crash it by enabling DXVA2 video output and loading any video :-D

hiro

  • Jr. Member
  • **
  • Posts: 59
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #6 on: December 30, 2019, 09:17:58 PM »
There must be some kind of "bug~in~your~crash~test~advice"...

See? I finally found one!:

so, here we go: (on Win. XP SP2) after activating DXVA2 and trying to drop several types of vids. onto this new ADM, not only they display perfectly, moreover, they (also) happen to PLAY... like a breeze.
« Last Edit: December 30, 2019, 09:37:53 PM by hiro »

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #7 on: December 31, 2019, 10:50:40 PM »
Did you restart Avidemux after enabling DXVA2? (Did you enable also hw accelerated decoding?)

I'd be curious to see admlog.txt from such a session.

hiro

  • Jr. Member
  • **
  • Posts: 59
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #8 on: January 04, 2020, 03:30:43 PM »
Yes, I did restart Avidemux after setting it to "DXVA2" – several times (several tests).

"hw accelerated decoding"? Do you mean "Video display: DXVA2 (best)"? If so, yes.

+ "HW Accel": tried about every option...

See attached screenshot(s) – and "admlog.txt".

eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #9 on: January 04, 2020, 04:06:18 PM »
Thank you, indeed, dxva2.dll is not found and thus checks which I suspected might crash Avidemux skipped = no crash.

Quote
Code: [Select]
[indexify] 14:36:28-796 Build Track index, track timescale: 24000
[indexify] 14:36:28-796 Histogram map has 3 elements.
Frame duration 1000 count: 240
Frame duration 1001 count: 241
Frame duration 1002 count: 239
[indexify] 14:36:28-796 Checking whether we need to fix jitter from rounding errors...
[indexify] 14:36:28-796 Yes, enforcing CFR, frame duration 1001 ticks.
[indexify] 14:36:28-796 Video index done.
[indexify] 14:36:28-796 Setting video timebase to 1001 / 24000

Glad to see this. We correctly identify timestamp jitter caused by an earlier Avidemux version and fix it. When saved in copy mode or re-encoded, the resulting video will have a constant frame rate again.

hiro

  • Jr. Member
  • **
  • Posts: 59
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #10 on: January 04, 2020, 05:04:46 PM »
Yep, I sure am a "CFR (oldschool?) aficionado" in all cases!

I've read about "VFR benefits" – which never convinced me, knowing the trouble I went thru, due to ("smart"phones) "VFR" vids...

... that I'd rather keep away from when possible / or convert at once! But that was a few years ago, OK.

__________

Now, about:

"Cannot load dxva2.dll
This binary has no DXVA2 support
("what~a~shame!")
DXVA2 not available",

I mean... should I "worry"? I might not know "what I'm missing", but I guess I won't fuss, as everything's working fine (so~far).



eumagga0x2a

  • Moderator
  • Hero Member
  • *****
  • Posts: 3692
Re: "2.7.5 r191130_win32" crash on drag-drop: bug or not?
« Reply #11 on: January 04, 2020, 11:53:24 PM »
Yep, I sure am a "CFR (oldschool?) aficionado" in all cases!

This has nothing to do with personal preferences, just with correcting my own errors. I made changes in Avidemux code which solved the problem of frequent failures to save a video due to timestamp collisions but at the same time exposed an older bug which resulted in incorrect rounding of timestamps. Now both the old bug as well as my error are fixed (effective especially for mp4 as source and as target format) by disentangling frame rate (fps) from time base which is an assumption that all timestamps in the video can be represented as a multiple of "number of clock ticks" divided by "clock frequency" (number of clock ticks per second), in this case 1001/24000.

By passing this fraction all the way down to muxer, Avidemux ensures now that the saved file will get the same (or a compatible) time base and also retain the CFR property of the source.

Quote
I've read about "VFR benefits" – which never convinced me, knowing the trouble I went thru, due to ("smart"phones) "VFR" vids...

Again, this is not about benefits or drawbacks. As you noticed, most (all?) smartphones (Android ones much more than iPhones, but iPhones as well) record variable frame rate mp4 videos. Our task is to preserve original timestamps (actually, the durations of each frame, so that a different start offset doesn't hurt) as good as possible which is essential for A/V sync, not to falsify them by forcing a fake CFR.

Quote
Now, about:

"Cannot load dxva2.dll
This binary has no DXVA2 support
("what~a~shame!")
DXVA2 not available",

I mean... should I "worry"?

No, not at all. DirectX hardware accelerated video decoding was introduced only in later Windows versions (Vista?).