gcc 4.8.1 compile failure

[ajschult]

I upgraded to Fedora 19 (gcc 4.8.1) and now get

Code Select Expand


/build/andrew/avidemux/avidemux_2.6.0/avidemux/qt4/ADM_UIs/src/T_filesel.cpp: In member function ââ,¬Ëœvoid ADM_Qt4Factory::ADM_Qfilesel::buttonPressed(QAbstractButton*)ââ,¬â,,¢:
/build/andrew/avidemux/avidemux_2.6.0/avidemux/qt4/ADM_UIs/src/T_filesel.cpp:64:5: warning: deprecated conversion from string constant to ââ,¬Ëœchar*ââ,¬â,,¢ [-Wwrite-strings]
  txt="";
     ^


ADM_Qfilesel::buttonPressed looks like

Code Select Expand


        char buffer[MAX_SEL+1],*txt;
        txt="";


[ajschult]

Of course... warnings don't cause build failures...

The real problem was that various bits of libva code are in XVBA sections (I have libva but not xvba)

Code Select Expand


Index: avidemux/common/ADM_videoCodec/include/ADM_codecLibVA.h
===================================================================
--- avidemux/common/ADM_videoCodec/include/ADM_codecLibVA.h     (revision 8768)
+++ avidemux/common/ADM_videoCodec/include/ADM_codecLibVA.h     (working copy)
@@ -2,7 +2,7 @@
         \file FFLIBVA
  *      \brief wrapper around ffmpeg wrapper around libva
  */
-#ifdef USE_XVBA
+#ifdef USE_LIBVA
#include "X11/Xlib.h"
#include "va/va.h"

Index: avidemux/common/ADM_videoCodec/src/ADM_ffmpeg_libva.cpp
===================================================================
--- avidemux/common/ADM_videoCodec/src/ADM_ffmpeg_libva.cpp     (revision 8768)
+++ avidemux/common/ADM_videoCodec/src/ADM_ffmpeg_libva.cpp     (working copy)
@@ -20,7 +20,7 @@
#include "BVector.h"
#include "ADM_default.h"

-#ifdef USE_XVBA
+#ifdef USE_LIBVA
extern "C" {
#include "libavcodec/avcodec.h"
#include "libavutil/pixfmt.h"
Index: avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA.cpp
===================================================================
--- avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA.cpp    (revision 8768)
+++ avidemux_core/ADM_coreVideoCodec/ADM_hwAccel/ADM_coreLibVA/src/ADM_coreLibVA.cpp    (working copy)
@@ -17,7 +17,7 @@
#include "../include/ADM_coreLibVA.h"
#include "va/va_x11.h"

-#ifdef USE_XVBA
+#ifdef USE_LIBVA
#include "../include/ADM_coreLibVA_internal.h"
#include "ADM_dynamicLoading.h"
#include "ADM_windowInfo.h"


[Jan Gruuthuse]

WARNING: don't install the AMD driver if you don't have AMD video card!

no need to install the proprietary AMD driver or to desinstall vdpau
just copy the .h file

Wild guess: see if xvba-sdk helps solving this issue: XVBA ubuntu

just copy amdxvba.h to /usr/include/amd, that's enough
The file is in the amxvba_sdk.tar.gz

If this don't work: sorry

[mean]

Fixed, thanks

[mit]

Now i got this:

Code Select Expand

...
commonQt4/ADM_videoCodec/src/libADM_videocodec6.a(ADM_ffmpeg_libva.cpp.o): In function `libvaProbe()':
ADM_ffmpeg_libva.cpp:(.text+0x477): undefined reference to `admLibVA::init(GUI_WindowInfo*)'
commonQt4/ADM_videoCodec/src/libADM_videocodec6.a(ADM_ffmpeg_libva.cpp.o): In function `libvaCleanup()':
ADM_ffmpeg_libva.cpp:(.text+0x441): undefined reference to `admLibVA::cleanup()'
collect2: ld returned 1 exit status

[mean]

Maybe ok now

[mit]

Maybe ok now

Yep, thanks!