[pulseaudiosimple] WARNING: you are using the obsolete 'PKGCONFIG' macro...

[sl1pkn07]

Code Select Expand


-- Checking for PULSEAUDIOSIMPLE
-- *****************************
-- WARNING: you are using the obsolete 'PKGCONFIG' macro, use FindPkgConfig
-- Found PulseAudio Simple: /usr/lib64/libpulse-simple.so
-- HACK : we need both libpulse and libpulse-simple when using -W-l,-z,defs


and need space after HACK for avoid join info with vpx

Code Select Expand


--snip
-- Linker Flags  :

-- Checking for PULSEAUDIOSIMPLE
-- *****************************
-- WARNING: you are using the obsolete 'PKGCONFIG' macro, use FindPkgConfig
-- Found PulseAudio Simple: /usr/lib64/libpulse-simple.so
-- HACK : we need both libpulse and libpulse-simple when using -W-l,-z,defs
-- Checking for Vpx
-- *****************
-- Found vpx/vpx_decoder.h
--snip


[eumagga0x2a]

The following patch WFM:

Code Select Expand

diff --git a/cmake/admCheckAudioDeviceLibs.cmake b/cmake/admCheckAudioDeviceLibs.cmake
index 4292d41..fd5da22 100644
--- a/cmake/admCheckAudioDeviceLibs.cmake
+++ b/cmake/admCheckAudioDeviceLibs.cmake
@@ -165,20 +165,13 @@ IF (UNIX AND NOT APPLE)

            # use pkg-config to get the directories and then use these values
         # in the FIND_PATH() and FIND_LIBRARY() calls
-        INCLUDE(UsePkgConfig)
-        PKGCONFIG(libpulse-simple _PASIncDir _PASLinkDir _PASLinkFlags _PASCflags)
-        SET(PULSEAUDIOSIMPLE_DEFINITIONS ${_PASCflags})
-
-        FIND_PATH(PULSEAUDIOSIMPLE_INCLUDE_DIR pulse/simple.h
-        PATHS
-        ${_PASIncDir}
-        PATH_SUFFIXES pulse
-        )
-
-        FIND_LIBRARY(PULSEAUDIOSIMPLE_LIBRARIES NAMES pulse-simple libpulse-simple
-        PATHS
-        ${_PASLinkDir}
-        )
+        include(FindPkgConfig)
+        pkg_check_modules(PULSEAUDIOSIMPLE libpulse-simple)
+        IF (PULSEAUDIOSIMPLE_FOUND)
+          SET(PULSEAUDIOSIMPLE_DEFINITIONS ${PULSEAUDIOSIMPLE_CFLAGS})
+          FIND_PATH(PULSEAUDIOSIMPLE_INCLUDE_DIR pulse/simple.h PATHS ${PULSEAUDIOSIMPLE_INCLUDE_DIRS} PATH_SUFFIXES pulse)
+          FIND_LIBRARY(PULSEAUDIOSIMPLE_LIBRARIES NAMES pulse-simple libpulse-simple PATHS ${PULSEAUDIOSIMPLE_LIBRARY_DIRS})
+        ENDIF (PULSEAUDIOSIMPLE_FOUND)

         IF (PULSEAUDIOSIMPLE_INCLUDE_DIR AND PULSEAUDIOSIMPLE_LIBRARIES)
          SET(PULSEAUDIOSIMPLE_FOUND TRUE)

I could neither find a working solution without the FIND_PATH hack nor understand why such solution fails.

A trivial patch for an empty line after the "HACK :" message is attached too.

[sl1pkn07]

tnx for the patch

the pkgconfig patch works ok, but the add space not at all

Code Select Expand


-- Checking for PULSEAUDIOSIMPLE
-- *****************************
-- Checking for module 'libpulse-simple'
--   Found libpulse-simple, version 9.0
-- Found PulseAudio Simple: pulse-simple;pulse
-- HACK : we need both libpulse and libpulse-simple when using -W-l,-z,defs
--
-- Checking for Vpx
-- *****************
-- Found vpx/vpx_decoder.h
-- Found vpx library
-- Found vpx_codec_dec_init_ver in /usr/lib64/libvpx.so
-- Found Vpx
-- Compiler Flags: /usr/include
-- Linker Flags  : /usr/lib64/libvpx.so
-- Linking to vpx decoder library

-- Checking for Aften


Code Select Expand


diff --git a/avidemux_plugins/ADM_audioDevices/PulseAudioSimple/CMakeLists.txt b/avidemux_plugins/ADM_audioDevices/PulseAudioSimple/CMakeLists.txt
index 84530f2..6332615 100644
--- a/avidemux_plugins/ADM_audioDevices/PulseAudioSimple/CMakeLists.txt
+++ b/avidemux_plugins/ADM_audioDevices/PulseAudioSimple/CMakeLists.txt
@@ -7,5 +7,6 @@ ADD_AUDIO_DEVICE(ADM_av_pulseAudioSimple  ${ADM_av_pulseAudioSimple_SRCS})
ADD_DEFINITIONS(${PULSEAUDIOSIMPLE_DEFINITIONS})
TARGET_LINK_LIBRARIES(ADM_av_pulseAudioSimple ${PULSEAUDIOSIMPLE_LIBRARIES} pulse)
MESSAGE(STATUS "HACK : we need both libpulse and libpulse-simple when using -W-l,-z,defs")
+MESSAGE("")
INIT_AUDIO_DEVICE(ADM_av_pulseAudioSimple)
INSTALL_AUDIO_DEVICE(ADM_av_pulseAudioSimple)


Code Select Expand


-- Checking for PULSEAUDIOSIMPLE
-- *****************************
-- Checking for module 'libpulse-simple'
--   Found libpulse-simple, version 9.0
-- Found PulseAudio Simple: pulse-simple;pulse
-- HACK : we need both libpulse and libpulse-simple when using -W-l,-z,defs

-- Checking for Vpx
-- *****************


[eumagga0x2a]

Thx, I forgot to remove STATUS from MESSAGE(). But what was wrong with your version with \n for newline? Actually, an empty line or a newline at the end of a message would be needed also in cmake/admCheckAudioDeviceLibs.cmake as

Code Select Expand

@@ -192,7 +185,7 @@ IF (UNIX AND NOT APPLE)
         ENDIF (NOT PULSEAUDIOSIMPLE_FIND_QUIETLY)
         SET(USE_PULSE_SIMPLE 1)
         ELSE (PULSEAUDIOSIMPLE_FOUND)
-         MESSAGE(STATUS "Could NOT find PulseAudioSimple")
+         MESSAGE(STATUS "Could NOT find PulseAudioSimple\n")
         ENDIF (PULSEAUDIOSIMPLE_FOUND)

         MARK_AS_ADVANCED(PULSEAUDIOSIMPLE_INCLUDE_DIR PULSEAUDIOSIMPLE_LIBRARIES)

By the way, my attempts to find a solution without FIND_PATH failed because pkg_check_modules() or pkg_search_module() didn't find the header.

Once again, the same patch for cmake/admCheckAudioDeviceLibs.cmake but with newline and a patch with the newline cosmetics for avidemux_plugins/ADM_audioDevices/PulseAudioSimple/CMakeLists.txt.

[sl1pkn07]

Wrong nothing, but with MESSAGE follow the upstream

EDIT: add patch with MESSAGE("") instead of a \n