fixed: 9015225 play preview applied filter (rotate) in main GUI

[Jan Gruuthuse]

update: fixed: 9015225            Reinstate display resizing on playback, otherwise we crash in filter preview mode
Ubuntu 16.04.2 lts 64-bit with commits:
20170611: 9a8f630
20170613: 2709647 a37fd96

applied filter rotate on 720p with MPEG4 AVC (x264)
preview in filter is fine, play preview on main GUI gives this result:
pop-up window avidemux3_qt5:

Code Select Expand

Assert failed :src->_width==_width
at line 78, file /home/jan/avidemux2/avidemux_core/ADM_coreImage/src/ADM_imageOperation.cpp
ADM_backTrack
ADMImage::duplicateFull(ADMImage*)
ADM_videoFilterQueue::getNextFrameAs(ADM_HW_IMAGE, unsigned int*, ADMImage*)
GUIPlayback::run()
GUI_PlayAvi()
HandleAction(Action)
/usr/bin/avidemux3_qt5() [0x4af3c6]
QMetaObject::activate(QObject*, int, int, void**)
MainWindow::actionSignal(Action)
MainWindow::buttonPressed()
/usr/bin/avidemux3_qt5() [0x4af42c]
QMetaObject::activate(QObject*, int, int, void**)
QAbstractButton::clicked(bool)


QAbstractButton::mouseReleaseEvent(QMouseEvent*)
QToolButton::mouseReleaseEvent(QMouseEvent*)
QWidget::event(QEvent*)
QToolButton::event(QEvent*)
QApplicationPrivate::notify_helper(QObject*, QEvent*)
QApplication::notify(QObject*, QEvent*)
QCoreApplication::notifyInternal(QObject*, QEvent*)
QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool)


QApplicationPrivate::notify_helper(QObject*, QEvent*)
QApplication::notify(QObject*, QEvent*)
QCoreApplication::notifyInternal(QObject*, QEvent*)
QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*)
QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*)

Terminal output:

Code Select Expand

*********** BACKTRACK **************
/usr/lib/libADM_core6.so(ADM_backTrack+0x60) [0x7faca1f08cd0]:0:<ADM_backTrack>:-2
/usr/lib/libADM_coreImage6.so(_ZN8ADMImage13duplicateFullEPS_+0x2c) [0x7faca12baaac]:1:<ADMImage::duplicateFull(ADMImage*)>:0
/usr/bin/avidemux3_qt5(_ZN20ADM_videoFilterQueue14getNextFrameAsE12ADM_HW_IMAGEPjP8ADMImage+0x96) [0x48bce6]:2:<ADM_videoFilterQueue::getNextFrameAs(ADM_HW_IMAGE, unsigned int*, ADMImage*)>:0
/usr/bin/avidemux3_qt5(_ZN11GUIPlayback3runEv+0x7c) [0x4563dc]:3:<GUIPlayback::run()>:0
/usr/bin/avidemux3_qt5(_Z11GUI_PlayAviv+0x100) [0x456900]:4:<GUI_PlayAvi()>:0
/usr/bin/avidemux3_qt5(_Z12HandleAction6Action+0x70c) [0x45497c]:5:<HandleAction(Action)>:0
/usr/bin/avidemux3_qt5() [0x4af3c6]:6:</usr/bin/avidemux3_qt5() [0x4af3c6]>:0
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN11QMetaObject8activateEP7QObjectiiPPv+0x7ea) [0x7fac9e0e9d2a]:7:<QMetaObject::activate(QObject*, int, int, void**)>:0
/usr/bin/avidemux3_qt5(_ZN10MainWindow12actionSignalE6Action+0x3e) [0x4aee6e]:8:<MainWindow::actionSignal(Action)>:0
/usr/bin/avidemux3_qt5(_ZN10MainWindow13buttonPressedEv+0x137) [0x48fe27]:9:<MainWindow::buttonPressed()>:0
/usr/bin/avidemux3_qt5() [0x4af42c]:10:</usr/bin/avidemux3_qt5() [0x4af42c]>:0
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN11QMetaObject8activateEP7QObjectiiPPv+0x7ea) [0x7fac9e0e9d2a]:11:<QMetaObject::activate(QObject*, int, int, void**)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN15QAbstractButton7clickedEb+0x42) [0x7fac9efec2b2]:12:<QAbstractButton::clicked(bool)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(+0x257f44) [0x7fac9ed4ef44]:13:<>:-2
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(+0x259559) [0x7fac9ed50559]:14:<>:-2
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN15QAbstractButton17mouseReleaseEventEP11QMouseEvent+0xf4) [0x7fac9ed506d4]:15:<QAbstractButton::mouseReleaseEvent(QMouseEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN11QToolButton17mouseReleaseEventEP11QMouseEvent+0xa) [0x7fac9ee1526a]:16:<QToolButton::mouseReleaseEvent(QMouseEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN7QWidget5eventEP6QEvent+0x668) [0x7fac9ec94fc8]:17:<QWidget::event(QEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN11QToolButton5eventEP6QEvent+0x79) [0x7fac9ee15349]:18:<QToolButton::event(QEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0x8c) [0x7fac9ec5205c]:19:<QApplicationPrivate::notify_helper(QObject*, QEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x959) [0x7fac9ec57c19]:20:<QApplication::notify(QObject*, QEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN16QCoreApplication14notifyInternalEP7QObjectP6QEvent+0xdb) [0x7fac9e0bb38b]:21:<QCoreApplication::notifyInternal(QObject*, QEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN19QApplicationPrivate14sendMouseEventEP7QWidgetP11QMouseEventS1_S1_PS1_R8QPointerIS0_Eb+0x3c2) [0x7fac9ec56b32]:22:<QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(+0x1b85bb) [0x7fac9ecaf5bb]:23:<>:-2
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(+0x1bab7b) [0x7fac9ecb1b7b]:24:<>:-2
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0x8c) [0x7fac9ec5205c]:25:<QApplicationPrivate::notify_helper(QObject*, QEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x256) [0x7fac9ec57516]:26:<QApplication::notify(QObject*, QEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5(_ZN16QCoreApplication14notifyInternalEP7QObjectP6QEvent+0xdb) [0x7fac9e0bb38b]:27:<QCoreApplication::notifyInternal(QObject*, QEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5(_ZN22QGuiApplicationPrivate17processMouseEventEPN29QWindowSystemInterfacePrivate10MouseEventE+0x281) [0x7fac9e6a14e1]:28:<QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*)>:0
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5(_ZN22QGuiApplicationPrivate24processWindowSystemEventEPN29QWindowSystemInterfacePrivate17WindowSystemEventE+0x135) [0x7fac9e6a31a5]:29:<QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*)>:0
*********** BACKTRACK **************

Code Select Expand

Crash Dump for Crash
Assert failed :src->_width==_width
at line 78, file /home/jan/avidemux2/avidemux_core/ADM_coreImage/src/ADM_imageOperation.cpp
ADM_backTrack
ADMImage::duplicateFull(ADMImage*)
ADM_videoFilterQueue::getNextFrameAs(ADM_HW_IMAGE, unsigned int*, ADMImage*)
GUIPlayback::run()
GUI_PlayAvi()
HandleAction(Action)
/usr/bin/avidemux3_qt5() [0x4af3c6]
QMetaObject::activate(QObject*, int, int, void**)
MainWindow::actionSignal(Action)
MainWindow::buttonPressed()
/usr/bin/avidemux3_qt5() [0x4af42c]
QMetaObject::activate(QObject*, int, int, void**)
QAbstractButton::clicked(bool)


QAbstractButton::mouseReleaseEvent(QMouseEvent*)
QToolButton::mouseReleaseEvent(QMouseEvent*)
QWidget::event(QEvent*)
QToolButton::event(QEvent*)
QApplicationPrivate::notify_helper(QObject*, QEvent*)
QApplication::notify(QObject*, QEvent*)
QCoreApplication::notifyInternal(QObject*, QEvent*)
QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool)


QApplicationPrivate::notify_helper(QObject*, QEvent*)
QApplication::notify(QObject*, QEvent*)
QCoreApplication::notifyInternal(QObject*, QEvent*)
QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*)
QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*)

chrash.py:

Code Select Expand

#PY  <- Needed to identify #
#--automatically built--

adm = Avidemux()
adm.loadVideo("/home/jan/Videos/720p4audioTracks3satá´´á´°.ts")
adm.clearSegments()
adm.addSegment(0, 0, 37930000)
adm.markerA = 0
adm.markerB = 37930000
adm.videoCodec("x264", "useAdvancedConfiguration=True", "general.params=AQ=20", "general.threads=99", "general.preset=", "general.tuning=", "general.profile=", "general.fast_decode=False", "general.zero_latency=False", "general.fast_first_pass=True"
, "general.blueray_compatibility=False", "general.fake_interlaced=False", "level=-1", "vui.sar_height=1", "vui.sar_width=1", "MaxRefFrames=3", "MinIdr=25", "MaxIdr=250", "i_scenecut_threshold=40", "intra_refresh=False"
, "MaxBFrame=3", "i_bframe_adaptive=1", "i_bframe_bias=0", "i_bframe_pyramid=2", "b_deblocking_filter=True", "i_deblocking_filter_alphac0=0", "i_deblocking_filter_beta=0", "cabac=True", "interlaced=False"
, "constrained_intra=False", "tff=True", "fake_interlaced=False", "analyze.b_8x8=True", "analyze.b_i4x4=True", "analyze.b_i8x8=True", "analyze.b_p8x8=True", "analyze.b_p16x16=False", "analyze.b_b16x16=False"
, "analyze.weighted_pred=2", "analyze.weighted_bipred=True", "analyze.direct_mv_pred=1", "analyze.chroma_offset=0", "analyze.me_method=1", "analyze.me_range=16", "analyze.mv_range=-1", "analyze.mv_range_thread=-1"
, "analyze.subpel_refine=7", "analyze.chroma_me=True", "analyze.mixed_references=True", "analyze.trellis=1", "analyze.psy_rd=1.000000", "analyze.psy_trellis=0.000000", "analyze.fast_pskip=True", "analyze.dct_decimate=True"
, "analyze.noise_reduction=0", "analyze.psy=True", "analyze.intra_luma=11", "analyze.inter_luma=21", "ratecontrol.rc_method=0", "ratecontrol.qp_constant=0", "ratecontrol.qp_min=10", "ratecontrol.qp_max=51"
, "ratecontrol.qp_step=4", "ratecontrol.bitrate=0", "ratecontrol.rate_tolerance=1.000000", "ratecontrol.vbv_max_bitrate=0", "ratecontrol.vbv_buffer_size=0", "ratecontrol.vbv_buffer_init=1", "ratecontrol.ip_factor=1.400000"
, "ratecontrol.pb_factor=1.300000", "ratecontrol.aq_mode=1", "ratecontrol.aq_strength=1.000000", "ratecontrol.mb_tree=True", "ratecontrol.lookahead=40")
adm.addVideoFilter("rotate", "angle=270")
adm.audioClearTracks()
adm.setSourceTrackLanguage(0,"unknown")
adm.setSourceTrackLanguage(1,"unknown")
adm.setSourceTrackLanguage(2,"unknown")
adm.setSourceTrackLanguage(3,"unknown")
adm.audioAddTrack(0)
adm.audioCodec(0, "copy");
adm.audioSetDrc(0, 0)
adm.audioSetShift(0, 0,0)
adm.audioAddTrack(1)
adm.audioCodec(1, "copy");
adm.audioSetDrc(1, 0)
adm.audioSetShift(1, 0,0)
adm.audioAddTrack(2)
adm.audioCodec(2, "copy");
adm.audioSetDrc(2, 0)
adm.audioSetShift(2, 0,0)
adm.audioAddTrack(3)
adm.audioCodec(3, "copy");
adm.audioSetDrc(3, 0)
adm.audioSetShift(3, 0,0)
adm.setContainer("MKV", "forceDisplayWidth=False", "displayWidth=1280")

[eumagga0x2a]

Now I know what this resizing on playback is for
Should be fixed by [GUI] Reinstate display resizing on playback, otherwise we crash in filter preview mode. Thank you for catching this.

[Jan Gruuthuse]

commit 9015225            Reinstate display resizing on playback, otherwise we crash in filter preview mode did fix the issue.
thnx