Avidemux crashes trying to index TS file from DVB

[radorn]

I record stuff from digital TV (DVB) and chop it up in Avidemux.
I never saw it crash trying to index them before

Code Select Expand

Problem signature:
  Problem Event Name: BEX64
  Application Name: avidemux.exe
  Application Version: 2.8.1.22260
  Application Timestamp: 6325b96b
  Fault Module Name: libADM_dm_ts.dll
  Fault Module Version: 0.0.0.0
  Fault Module Timestamp: 6325b9e8
  Exception Offset: 0000000000013e60
  Exception Code: c0000409
  Exception Data: 0000000000000000
  OS Version: 6.1.7601.2.1.0.256.1
  Locale ID: 2057
  Additional Information 1: e3e0
  Additional Information 2: e3e041a5398338c5d62bdf578c10a3e9
  Additional Information 3: b4ba
  Additional Information 4: b4ba6444fb46623091b64763799d9a0c
After fiddling a good while with the file in a hex editor, I narrowed the problem to the first 14MB of the file. If I chop that off, the rest of the stream works fine, as usual.
The chopped off chunk crashes Avidemux, of course.
Should I upload it?

[eumagga0x2a]

Yes, please.

[eumagga0x2a]

Please don't start duplicate topics. If you experience problems posting the link to uploaded sample, please send me that link via a personal message, thank you.

[radorn]

duplicate topics? hmmm, perhaps I did... sorry too many tabs and doing too many things at the same time.

Anyway, here's the file https://ufile.io/0nupysmi

[eumagga0x2a]

Thank you for the sample, confirming the crash, will look into it.

[eumagga0x2a]

Should be fixed by this changeset which corrects handling of a PSI (program-specific information) checksum failure.

However, the stream seems to be so heavily corrupted at the start of the file, that we get FPS totally wrong due to damaged SPS in the H.264 video stream and also discard the Spanish audio track. Therefore, cutting away the first MiB is the most sensible thing to do in this particular case.

[radorn]

Thanks for the fix.
It's weird because that file played fine in SMPlayer. No complaints there.
I don't contest the fact that it was corrupt, though, being a DVB-T rip.
I didn't notice the problem with the Spanish audio as I usually just don't listen to it. I was used to Spanish dub work in the past, not knowing any better, but nowadays I find it most of it terrible. Sometimes it's OK or even good, I guess, but I don't bother with it anymore. If the original audio is English I go with it. But I do keep the Spanish track in some stuff just in case the English audio is too obscure for my ears and I can't figure out what's being said.
Some English spoken movies aren't too clear due to accent, diction, weird sound direction... making life harder for non-native speakers like me.

Anyway. I've had corrupt TS files before, with garbled video, or timeline problems, missing parts, etc, which I had to work around, and I didn't think much of any of it, coming from free-to-air TV. But until now, never did Avidemux choke to death on a file, so I thought it was worth reporting.

[eumagga0x2a]

Thank you for your report and the sample, which allowed to identify and fix the bug in the code.

Indeed, the combination of a damaged PSI table spanning multiple transport stream packages and the resulting checksum error for this table didn't come up in previous samples so far, letting the bug, introduced 10 months ago,  to remain unnoticed for so long.

[eumagga0x2a]

A 2.8.2 nightly for Windows containing the fix is now available at https://avidemux.org/nightly/win64/

[radorn]

Ah, that gives me an opportunity to ask about this:

It seems you guys keep three different compiles for 64-bit Windows?
One compiled with MS's Visual Whatever, and the other two with some *nix toolchain, one using KDE's (?) Qt GUI stuff.

I normally go with VS for size and because I noticed that non-VS win64 grays out the background of active dialog elements that should be "lit" (I don't know the correct lingo here). At least that's how it goes in my Windows7 setup with Classic theme.
Never tried the Qt version.

So, any particular recommendation for one of the three (when available, of course)?

[eumagga0x2a]

There are two different compilers and environments (native builds created using Microsoft Visual Studio and cross-builds created in a MXE by MinGW). The binaries created by latter are packaged in two different ways, an all-including ZIP archive and an NSIS installer which allows to deselect some components.

VC++ builds are packaged using Qt installer framework (I am not sure whether there were problems building NSIS with VC++ or the only idea was to investigate a cross-platform installer).

All builds include a graphical Qt application, a command-line application and a simple Qt-based application to launch queued jobs.

Please elaborate the focus issues you experience. This may be related to a more recent Qt version in MinGW builds.

There is no 2.8.2 VC++ nightly at the moment, so no choice.

You have to use VC++ builds if you want to be able to use VapourSynth. At the same time, they lack a couple of video filters compatible with MinGW only.

[radorn]

This is what I'm talking about:

Inactive dropdown/textbox
You cannot view this attachment.

active in vc++ version
You cannot view this attachment.

active in win64 (still grayed out)
You cannot view this attachment.

[eumagga0x2a]

active in win64 (still grayed out)

Does it mean that you cannot open the dropdown menu to select display aspect ratio in a MinGW build when "Force aspect ratio" is checked? Or is it purely a visual glitch? (Please note that the font is not grayed out.)

[radorn]

No, it works fine; it's just the visual aspect, which I why I didn't report it before.
It's been like this for as long as I started using WIP builds about a year ago.
I didn't report it since it wasn't a functional issue, but the flow of this conversation led me to bring it up.

[eumagga0x2a]

I didn't report it since it wasn't a functional issue,

Please don't hesitate to report all oddities you notice right away.

I've increased audio probe size, this allows Avidemux to detect both audio tracks in the untrimmed sample.

I'll check the color palette issue later.